Uh oh!
There was an error while loading. Please reload this page.
Stabilize vec_spare_capacity - #93016
Merged
Merged
Conversation
rust-highfive
commented
Jan 17, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jan 17, 2022
Contributor
|
Mark-Simulacrum
commented
Jan 17, 2022
Member
@bors r+ per FCP in #75017 (comment) |
bors
commented
Jan 17, 2022
Collaborator
📌 Commit e012b9a has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2022
…askrgr Rollup of 14 pull requests Successful merges: - rust-lang#92629 (Pick themes on settings page, not every page) - rust-lang#92640 (Fix ICEs related to `Deref<Target=[T; N]>` on newtypes) - rust-lang#92701 (Add some more attribute validation) - rust-lang#92803 (Hide mobile sidebar on some clicks) - rust-lang#92830 (Rustdoc style cleanups) - rust-lang#92866 ("Does exists" typos fix) - rust-lang#92870 (add `rustc_diagnostic_item` attribute to `AtomicBool` type) - rust-lang#92914 (htmldocck: Add support for `/text()` in ``@snapshot`)` - rust-lang#92923 (Abstract the pretty printer's ringbuffer to be infinitely sized) - rust-lang#92946 (Exclude llvm-libunwind from the self-contained set on s390x-musl targets) - rust-lang#92947 (rustdoc: Use `intersperse` in a `visit_path` function) - rust-lang#92997 (Add `~const` bound test for negative impls) - rust-lang#93004 (update codegen test for LLVM 14) - rust-lang#93016 (Stabilize vec_spare_capacity) Failed merges: - rust-lang#92924 (Delete pretty printer tracing) r? `@ghost` `@rustbot` modify labels: rollup
jethrogb
commented
Jan 18, 2022
Contributor
This stdarch commit is not in any branch. Can this PR be reverted? See #75109 for why this is bad. |
Amanieu
commented
Jan 18, 2022
MemberAuthor
I was hoping to merge rust-lang/stdarch#1272 once a new nightly comes out tonight. |
Amanieu added a commit
to Amanieu/rust
that referenced
this pull request
Jan 18, 2022
PR rust-lang#93016 was merged with the stdarch submodule pointing to a commit in a PR branch and not in master. This was due to a circular dependency between the rust and stdarch changes which would cause the other to fail to build. cc rust-lang#75109
Amanieu
commented
Jan 18, 2022
MemberAuthor
I merged the stdarch PR and opened #93035. |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2022
Fix stdarch submodule pointing to commit outside tree PR rust-lang#93016 was merged with the stdarch submodule pointing to a commit in a PR branch and not in master. This was due to a circular dependency between the rust and stdarch changes which would cause the other to fail to build. cc rust-lang#75109
nyurik added a commit
to nyurik/osmpbf
that referenced
this pull request
Jul 1, 2022
protobuf uses spare_capacity_mut on vectors that was stabilized in 1.60 rust-lang/rust#93016
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#75017