Skip to content

remove List::is_noop - #93077

Merged
bors merged 1 commit into
rust-lang:masterfrom
lcnr:write_substs
Jan 20, 2022
Merged

remove List::is_noop#93077
bors merged 1 commit into
rust-lang:masterfrom
lcnr:write_substs

Conversation

@lcnr

@lcnrlcnr commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

think that is_noop is actually less clear than just using is_empty

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 19, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2022
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jan 19, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 4bd571c has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2022
…askrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#92316 (mangling_v0: Skip extern blocks during mangling)
- rust-lang#92630 (Change PhantomData type for `BuildHasherDefault` (and more))
- rust-lang#92800 (Add manifest docs fallback.)
- rust-lang#93005 (Move back templates into html folder)
- rust-lang#93065 (Pretty printer algorithm revamp step 2)
- rust-lang#93077 (remove `List::is_noop`)
Failed merges:
- rust-lang#93068 (Fix spacing for `·` between stability and source)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 43d508b into rust-lang:masterJan 20, 2022
@rustbotrustbot added this to the 1.60.0 milestone Jan 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lcnr@rust-highfive@oli-obk@bors@rustbot