Uh oh!
There was an error while loading. Please reload this page.
Make Box drop through Drop trait - #93105
Conversation
rust-highfive
commented
Jan 20, 2022
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
763eba2 to
6059879Comparerust-log-analyzer
commented
Jan 20, 2022
The job Click to see the possible cause of the failure (guessed by this bot) |
beepster4096
commented
Jan 20, 2022
Alright good, now that CI is failing in the way it should, all we have to do is wait for #93028 to merge. |
nagisa
commented
Jan 22, 2022
I suspect this will run into problems with ensuring that the memory is indeed freed in case of incomplete initialization as part of the Would be a good idea to verify there are tests for these behaviours and if not – to implement some. |
beepster4096
commented
Jan 24, 2022
Actually, this is still going to need some compiler magic for dropping T because of some of Box's other magic. |
beepster4096
commented
Feb 27, 2022
Honestly, don't think this is that useful because of that. Not gonna bother finishing this. |
This PR makes Box drop through its implementation of the Drop trait, instead of by being special-cased in the compiler.
Blocked on #93028