Uh oh!
There was an error while loading. Please reload this page.
Add some known GAT bugs as tests - #93757
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
nikomatsakis
commented
Feb 9, 2022
Contributor
@bors rollup+ r+ |
jackh726
commented
Feb 9, 2022
MemberAuthor
Need to rebless the tests with TAITs (or maybe remove them if they aren't bugs anymore), since those outputs have changed after the lazy impl trait PR landed. |
jackh726
commented
Feb 12, 2022
MemberAuthor
With the lazy TAIT PR reverted, I actually don't have to do anything anymore @bors r=nikomatsakis rollup |
bors
commented
Feb 12, 2022
Collaborator
📌 Commit a38ff48 has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 12, 2022
Add some known GAT bugs as tests In the spirit of rust-lang/compiler-team#476 These tests are marked as "check-fail", but also commented with "this should pass". This many of the open GAT issues that are accepted bugs. r? `@nikomatsakis`
dtolnay
requested changes
Feb 12, 2022
dtolnay
left a comment
Member
There was a problem hiding this comment.
This failed in the rollup: #93929 (comment).
I saw some failures in this PR's status checks too. Not sure why those didn't get posted as a comment by @rust-log-analyzer.
failures: [ui] ui/generic-associated-types/bugs/issue-86218.rs [ui] ui/generic-associated-types/bugs/issue-87803.rs [ui] ui/generic-associated-types/bugs/issue-89008.rsUh oh!
There was an error while loading. Please reload this page.
jackh726
commented
Feb 12, 2022
MemberAuthor
@dtolnay test failures from CI were caused by the lazy TAIT PR, which has been reverted |
Co-authored-by: David Tolnay <dtolnay@gmail.com>
jackh726
commented
Feb 12, 2022
MemberAuthor
@bors r=nikomatsakis |
bors
commented
Feb 12, 2022
Collaborator
📌 Commit ba42215 has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 12, 2022
Add some known GAT bugs as tests In the spirit of rust-lang/compiler-team#476 These tests are marked as "check-fail", but also commented with "this should pass". This many of the open GAT issues that are accepted bugs. r? `@nikomatsakis`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 12, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91908 (Add 2 tests) - rust-lang#93595 (fix ICE when parsing lifetime as function argument) - rust-lang#93757 (Add some known GAT bugs as tests) - rust-lang#93759 (Pretty print ItemKind::Use in rustfmt style) - rust-lang#93897 (linkchecker: fix panic on directory symlinks) - rust-lang#93898 (tidy: Extend error code check) - rust-lang#93928 (Add missing release notes for rust-lang#85200) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2022
Add the `known-bug` test directive, use it, and do some cleanup cc rust-lang/compiler-team#476 Now tests can be annotated with `known-bug`, which should indicate that the test *should* pass (or at least that the current output is a bug). Adding it relaxes the requirement to add error annotations to the test (though it is still allowed). In the future, this could be extended with further relaxations - with the goal to make adding these tests need minimal effort. I've used this attribute for the GAT tests added in rust-lang#93757. Finally, I've also cleaned up `header.rs` in compiletest a bit, by extracting out a bit of common logic. I've also split out some of the directives into their own consts. This removes a lot of very similar functions from `Config` and makes `TestProps::load_from` read nicer. I've split these into separate commits, so I in theory could split these into separate PRs if they're controversial, but I think they're pretty straightforward. r? `@Mark-Simulacrum`
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 18, 2022
Add the `known-bug` test directive, use it, and do some cleanup cc rust-lang/compiler-team#476 Now tests can be annotated with `known-bug`, which should indicate that the test *should* pass (or at least that the current output is a bug). Adding it relaxes the requirement to add error annotations to the test (though it is still allowed). In the future, this could be extended with further relaxations - with the goal to make adding these tests need minimal effort. I've used this attribute for the GAT tests added in rust-lang#93757. Finally, I've also cleaned up `header.rs` in compiletest a bit, by extracting out a bit of common logic. I've also split out some of the directives into their own consts. This removes a lot of very similar functions from `Config` and makes `TestProps::load_from` read nicer. I've split these into separate commits, so I in theory could split these into separate PRs if they're controversial, but I think they're pretty straightforward. r? ``@Mark-Simulacrum``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of rust-lang/compiler-team#476
These tests are marked as "check-fail", but also commented with "this should pass". This many of the open GAT issues that are accepted bugs.
r? @nikomatsakis