Ensure stability directives are checked in all cases by cjgillot · Pull Request #94096 · rust-lang/rust

cjgillot · 2022-02-17T18:58:37Z

Split off #93017

Stability and deprecation were not checked in all cases, for instance if a type error happened.
This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases.

r? @lcnr

lcnr · 2022-02-18T11:06:38Z

are these just the first 7 commits from #93017? and if so, did you change anything meaningful about them after my first review? If not, r=me

cjgillot · 2022-02-18T12:34:09Z

I did not change anything except re-blessing tests after rebase.
@bors r=lcnr

bors · 2022-02-18T12:34:11Z

📌 Commit 5ff235b has been approved by lcnr

cjgillot · 2022-02-18T23:21:34Z

@bors try @rust-timer queue

rust-timer · 2022-02-18T23:21:35Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-02-18T23:21:36Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

cjgillot · 2022-02-18T23:22:08Z

Just in case.
@bors r-
@bors try @rust-timer queue

rust-timer · 2022-02-18T23:22:09Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-02-18T23:22:17Z

⌛ Trying commit 5ff235b with merge 1d32a80a10c46744f5200d5dab9e702510d85418...

bors · 2022-02-19T00:56:10Z

☀️ Try build successful - checks-actions
Build commit: 1d32a80a10c46744f5200d5dab9e702510d85418 (1d32a80a10c46744f5200d5dab9e702510d85418)

rust-timer · 2022-02-19T00:56:12Z

Queued 1d32a80a10c46744f5200d5dab9e702510d85418 with parent b17226f, future comparison URL.

rust-timer · 2022-02-19T06:14:40Z

Finished benchmarking commit (1d32a80a10c46744f5200d5dab9e702510d85418): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

cjgillot · 2022-02-19T10:44:19Z

@bors r=lcnr

bors · 2022-02-19T10:44:21Z

📌 Commit 5ff235b has been approved by lcnr

cjgillot · 2022-02-19T10:44:41Z

@bors rollup-

Ensure stability directives are checked in all cases Split off rust-lang#93017 Stability and deprecation were not checked in all cases, for instance if a type error happened. This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases. r? `@lcnr`

matthiaskrgr · 2022-03-02T19:10:18Z

Looks like tests needs to be reblessed
#94532 (comment)
I'm gonna rollup=never since this seems kinda fragile
@bors r- rollup=never

cjgillot · 2022-03-03T20:10:07Z

@bors r=lcnr

bors · 2022-03-03T20:10:09Z

📌 Commit c680d39 has been approved by lcnr

bors · 2022-03-04T05:49:17Z

⌛ Testing commit c680d39 with merge 65f6d33...

bors · 2022-03-04T08:14:25Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 65f6d33 to master...

rust-timer · 2022-03-04T11:24:16Z

Finished benchmarking commit (65f6d33): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 17, 2022

rust-highfive assigned lcnr Feb 17, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 19, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2022

cjgillot added 9 commits March 3, 2022 18:08

Move the set of features to the features query.
fbcf7d4

Remove useless map.
1b4b5e0

Move query providers.
6f8e9f4

Force ensure stability_index.
7183882

Bless test.
969f873

Gate stability attrs with other attributes.
3c7947e

Cleanup feature gates.
27d8cd7

Make unknown feature error deterministic.
42ffdd9

Bless nll tests.
c680d39

cjgillot force-pushed the ensure-stability branch from 4f880ba to c680d39Compare March 3, 2022 19:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2022

bors merged commit 65f6d33 into rust-lang:masterMar 4, 2022

rustbot added this to the 1.61.0 milestone Mar 4, 2022

This was referenced Mar 4, 2022
Stabilize naked_functions #93587
Closed
Stabilize const_fn_fn_ptr_basics, const_fn_trait_bound, and const_impl_trait #93827
Merged
Implement proper stability check for const impl Trait, fall back to unstable const when undeclared #93960
Closed

cjgillot deleted the ensure-stability branch March 4, 2022 20:26

madsmtm mentioned this pull request Oct 10, 2024
LLVM ERROR: Unsupported expression in static initializer (On macOS) #89225
Closed

i-like-ICEs mentioned this pull request Jun 10, 2026
codegen: Unnecessary memcpy when returning a mutated mut self#157685
Open

Uh oh!

Uh oh!

Conversation

cjgillot commented Feb 17, 2022

Uh oh!

lcnr commented Feb 18, 2022

Uh oh!

cjgillot commented Feb 18, 2022

Uh oh!

bors commented Feb 18, 2022

Uh oh!

cjgillot commented Feb 18, 2022

Uh oh!

rust-timer commented Feb 18, 2022

Uh oh!

bors commented Feb 18, 2022

Uh oh!

cjgillot commented Feb 18, 2022

Uh oh!

rust-timer commented Feb 18, 2022

Uh oh!

bors commented Feb 18, 2022

Uh oh!

bors commented Feb 19, 2022

Uh oh!

rust-timer commented Feb 19, 2022

Uh oh!

rust-timer commented Feb 19, 2022

Uh oh!

cjgillot commented Feb 19, 2022

Uh oh!

bors commented Feb 19, 2022

Uh oh!

cjgillot commented Feb 19, 2022

Uh oh!

matthiaskrgr commented Mar 2, 2022

Uh oh!

cjgillot commented Mar 3, 2022

Uh oh!

bors commented Mar 3, 2022

Uh oh!

bors commented Mar 4, 2022

Uh oh!

bors commented Mar 4, 2022

Uh oh!

rust-timer commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants