Uh oh!
There was an error while loading. Please reload this page.
Upgrade libc to fix Instant + Duration producing wrong result on aarch64-apple-darwin - #94100
Closed
lyinch wants to merge 9 commits into
Closed
Upgrade libc to fix Instant + Duration producing wrong result on aarch64-apple-darwin#94100lyinch wants to merge 9 commits into
Instant + Duration producing wrong result on aarch64-apple-darwin#94100lyinch wants to merge 9 commits into
Conversation
rust-highfive
commented
Feb 17, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon. Please see the contribution instructions for more information. |
Urgau
reviewed
Feb 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
bors added a commit
to rust-lang/libc
that referenced
this pull request
Feb 19, 2022
Bump version to 0.2.119 I'd like a new release because rust-lang/rust#94100 requires the merged PR: #2689
lyinch
marked this pull request as ready for review
February 19, 2022 15:42
yaahc
commented
Mar 18, 2022
Member
bors
commented
Mar 18, 2022
Collaborator
📌 Commit 283ccc9 has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 18, 2022
Issue rust-lang#91417 fix This is a regression test and a fixesrust-lang#91417 It also bumps the libc version to 0.2.119 because it requires the constant introduced here: rust-lang/libc#2689
klensy
commented
Mar 18, 2022
Contributor
libc update will likely fail similar to #94052 |
Dylan-DPC
commented
Mar 18, 2022
Member
@bors r- |
Instant + Duration producing wrong result on aarch64-apple-darwinbors
commented
Apr 5, 2022
Collaborator
☔ The latest upstream changes (presumably #95035) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
commented
Apr 23, 2022
ping from triage: FYI: when a PR is ready for review, send a message containing |
JohnCSimon
commented
May 22, 2022
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 18, 2022
Fix non-associativity of `Instant` math on `aarch64-apple-darwin` targets This is a duplicate of rust-lang#94100 (since the original author is unresponsive), which resolvesrust-lang#91417. On `aarch64-apple-darwin` targets, the internal resolution of `Instant` is lower than that of `Duration`, so math between them becomes non-associative with small-enough durations. This PR makes this target use the standard Unix implementation (where `Instant` has 1ns resolution), but with `CLOCK_UPTIME_RAW` so it still returns the same values as `mach_absolute_time`[^1]. (Edit: I need someone to confirm that this still works, I do not have access to an M1 device.) [^1]: https://www.manpagez.com/man/3/clock_gettime/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression test and a fixes#91417
It also bumps the libc version to 0.2.119 because it requires the constant introduced here: rust-lang/libc#2689