Uh oh!
There was an error while loading. Please reload this page.
Better errors when a Copy impl on a Struct is not self-consistent - #94249
Merged
Conversation
rust-highfive
commented
Feb 22, 2022
Contributor
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
davidtwco
requested changes
Mar 1, 2022
davidtwco
left a comment
Member
There was a problem hiding this comment.
Apologies for the slow review, I think this is a sensible change and looks good. I've left a small comment, if it seems feasible to fix without a lot more work then we can do that before landing this, otherwise it can be a follow-up.
Uh oh!
There was an error while loading. Please reload this page.
compiler-errorsforce-pushed
the
better-copy-errors
branch
from
March 23, 2022 01:12
38691eb to
ef85798Comparecompiler-errors
commented
Mar 23, 2022
ContributorAuthor
@rustbot ready I left a FIXME, but otherwise just rebased this code. |
compiler-errorsforce-pushed
the
better-copy-errors
branch
from
March 23, 2022 01:15
ef85798 to
c8cbd3dComparedavidtwco
approved these changes
Mar 23, 2022
davidtwco
commented
Mar 23, 2022
Member
@bors r+ |
bors
commented
Mar 23, 2022
Collaborator
📌 Commit c8cbd3d has been approved by |
bors
commented
Mar 23, 2022
Collaborator
⌛ Testing commit c8cbd3d with merge 5114b946e9d2e10226feb30bec8c2f2e24fe3113... |
bors
commented
Mar 23, 2022
Collaborator
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Mar 23, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
compiler-errors
commented
Mar 23, 2022
ContributorAuthor
can someone bors-retry this? spurious error it seems. |
nnethercote
commented
Mar 23, 2022
Contributor
@bors retry |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 23, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#94249 (Better errors when a Copy impl on a Struct is not self-consistent) - rust-lang#95069 (Fix auto traits in rustdoc) - rust-lang#95221 (interpret/memory: simplify check_and_deref_ptr) - rust-lang#95225 (remove `[async output]` from `impl Future` pretty-printing) - rust-lang#95238 (Stop emitting E0026 for struct enums with underscores) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered in a Zulip thread with @nnethercote and @Mark-Simulacrum, it's not immediately obvious why a field on an ADT doesn't implement
Copy. This PR attempts to give slightly more detailed information by spinning up a fulfillment context to try to dig down and discover transitive fulfillment errors that causeis_copy_modulo_regionsto fail on a ADT field.The error message still kinda sucks, but should only show up in the case that an existing error message was totally missing... so I think it's a good compromise for now?