Skip to content

riscv32imc_esp_espidf: set max_atomic_width to 64 - #94292

Merged
bors merged 1 commit into
rust-lang:masterfrom
esp-rs:riscv32imc-esp-espidf-64bit-atomics
Feb 24, 2022
Merged

riscv32imc_esp_espidf: set max_atomic_width to 64#94292
bors merged 1 commit into
rust-lang:masterfrom
esp-rs:riscv32imc-esp-espidf-64bit-atomics

Conversation

@MabezDev

Copy link
Copy Markdown
Contributor

For espidf targets without native atomics, there is atomic emulation inside the newlib component of espidf, this has been extended to support emulation up to 64bits therefore we are safe to increase the atomic width for the riscv32imc_esp_espidf target.

Closesesp-rs#107

cc: @ivmarkov

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 23, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2022

@ivmarkovivmarkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 65614e9 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2022
…askrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#89887 (Change `char` type in debuginfo to DW_ATE_UTF)
- rust-lang#94267 (Remove unused ordering derivations and bounds for `SimplifiedTypeGen`)
- rust-lang#94270 (Miri: relax fn ptr check)
- rust-lang#94273 (add matching doc to errorkind)
- rust-lang#94283 (remove feature gate in control_flow examples)
- rust-lang#94288 (Cleanup a few Decoder methods)
- rust-lang#94292 (riscv32imc_esp_espidf: set max_atomic_width to 64)
- rust-lang#94296 (:arrow_up: rust-analyzer)
- rust-lang#94300 (Fix a typo in documentation of `array::IntoIter::new_unchecked`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a93be6d into rust-lang:masterFeb 24, 2022
@rustbotrustbot added this to the 1.61.0 milestone Feb 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase esp STD targets max_atomic_width to 64?

6 participants

@MabezDev@rust-highfive@petrochenkov@bors@ivmarkov@rustbot