Uh oh!
There was an error while loading. Please reload this page.
Revert implementation of slice::swap - #94342
Merged
Merged
Conversation
Dylan-DPC
commented
Feb 25, 2022
Member
r? @Dylan-DPC |
Dylan-DPC
commented
Feb 25, 2022
Member
@bors r+ |
bors
commented
Feb 25, 2022
Collaborator
📌 Commit 072d35d has been approved by |
4 tasks
matthiaskrgr
commented
Feb 25, 2022
Member
@bors rollup=never |
bors
commented
Feb 25, 2022
Collaborator
bors
commented
Feb 26, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Feb 26, 2022
Collaborator
Finished benchmarking commit (d973b35): comparison url. Summary: This benchmark run did not return any relevant results. 6 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
m-ou-se
commented
Jun 27, 2022
Member
Should this be reverted again, since this made no difference in performance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the perf regressions noticed here, possible due to inlining? #88540 (comment)
r? @kennytm