Skip to content

Rename JoinHandle::is_running to is_finished. - #94549

Merged
bors merged 3 commits into
rust-lang:masterfrom
m-ou-se:thread-is-finished
Mar 4, 2022
Merged

Rename JoinHandle::is_running to is_finished.#94549
bors merged 3 commits into
rust-lang:masterfrom
m-ou-se:thread-is-finished

Conversation

@m-ou-se

@m-ou-sem-ou-se commented Mar 3, 2022

Copy link
Copy Markdown
Member

This is renaming is_running to is_finished as discussed on the tracking issue here: #90470 (comment)

Taking some of the docs suggestions from #94033

@m-ou-sem-ou-se added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 3, 2022
@rust-highfive

rust-highfive commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se
m-ou-seforce-pushed the thread-is-finished branch from a6e2f55 to af86b55CompareMarch 3, 2022 11:09
@taiki-etaiki-e mentioned this pull request Mar 3, 2022
Merged
@yaahc

yaahc commented Mar 3, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit af86b55 has been approved by yaahc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
db22fbb
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
24cedc2
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
962f4aa
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
c6f5e74
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
418a386
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
6dbeb02
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2022
@matthiaskrgr
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
5c0a1b6
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#94549- m-ou-se:thread-is-finished, r=yaahc
34ae383
Rename JoinHandle::is_running to is_finished.
This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment)
Taking some of the docs suggestions from rust-lang#94033
@bors
bors merged commit ee3a2c7 into rust-lang:masterMar 4, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 4, 2022
@m-ou-sem-ou-se mentioned this pull request Mar 9, 2022
Closed
8 tasks
@m-ou-se
m-ou-se deleted the thread-is-finished branch March 9, 2022 09:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yaahcyaahc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

6 participants

@m-ou-se@rust-highfive@rust-log-analyzer@yaahc@bors@rustbot