Uh oh!
There was an error while loading. Please reload this page.
Move theme picker button to the right and display it on all pages - #94607
Closed
GuillaumeGomez wants to merge 3 commits into
Closed
Move theme picker button to the right and display it on all pages#94607GuillaumeGomez wants to merge 3 commits into
GuillaumeGomez wants to merge 3 commits into
Conversation
rust-highfive
commented
Mar 4, 2022
Contributor
Some changes occurred in HTML/CSS/JS. |
GuillaumeGomezforce-pushed
the
theme-picker-display
branch
from
March 4, 2022 14:28
6e38299 to
d955a6aCompareUrgau
approved these changes
Mar 4, 2022
steffahn
commented
Mar 4, 2022
Member
Does not appear to display the theme picker in mobile. Is this intentional? I would prefer having it in mobile, too. |
GuillaumeGomez
commented
Mar 4, 2022
MemberAuthor
It's intentional. I'll make it appear on mobile as well and we can talk about it with @jsha then. |
GuillaumeGomez
commented
Mar 4, 2022
MemberAuthor
I made the mobile change in a separate commit and updated the online docs. It looks like this:
|
Urgau
commented
Mar 9, 2022
Member
Should this maybe be consider for back-porting ? |
GuillaumeGomez
commented
Mar 9, 2022
MemberAuthor
We already need to discuss it (the mobile part too). |
bors
commented
Apr 30, 2022
Collaborator
☔ The latest upstream changes (presumably #96566) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddle
commented
May 25, 2022
Contributor
#96958 makes this PR obsolete, doesn't it? |
GuillaumeGomez
commented
May 25, 2022
MemberAuthor
Absolutely! Thanks for closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#93216.
Kind of linked to #94048.
So more explanations about this: we received a lot of complains about the removal of the theme picker button. The idea behind this change was to reduce the visual distraction. We have a more global plan about settings to have them displayed like the "firefox pocket". To do so, the first step is #93097 (it's blocked on #90630 for the time being). Then once it's fully switched to JS, we can easily change how it's displayed.
So for the moment and as suggested, I move the theme picker button with the other ones one the right. It now looks like this:
You can test it online here.
r? @jsha