Skip to content

Fix spurious CI failures - #94779

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ci-spurious-failures
Mar 9, 2022
Merged

Fix spurious CI failures#94779
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ci-spurious-failures

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Mar 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This should fix the CI error encountered in #94774 (and multiple others).

cc @nikic

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 9, 2022
@rust-highfive

rust-highfive commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2022
@Dylan-DPC

Dylan-DPC commented Mar 9, 2022

Copy link
Copy Markdown
Member

@bors r+ p=50 rollup=never

@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 1c0bd57d4f36f3a5bea74d7ac48c1596153688ed has been approved by Dylan-DPC

@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1c0bd57d4f36f3a5bea74d7ac48c1596153688ed with merge 0ee66f91371c124eeaccf189524f591235d84c26...

This was referenced Mar 9, 2022
Merged
Merged
@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2022
@GuillaumeGomez

GuillaumeGomez commented Mar 9, 2022

Copy link
Copy Markdown
MemberAuthor

I commented the test and will look into it later.

@bors r=Dylan-DPC p=50 rollup=never

@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 18006a6 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 18006a6 with merge 458262b...

@nikicnikic mentioned this pull request Mar 9, 2022
Closed
@bors

bors commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 458262b to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 9, 2022
@bors
bors merged commit 458262b into rust-lang:masterMar 9, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 9, 2022
@rust-timer

rust-timer commented Mar 10, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (458262b): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez deleted the ci-spurious-failures branch March 10, 2022 09:22
@notriddlenotriddle mentioned this pull request Mar 21, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

8 participants

@GuillaumeGomez@rust-highfive@Dylan-DPC@bors@rust-timer@rust-log-analyzer@Mark-Simulacrum@rustbot