Uh oh!
There was an error while loading. Please reload this page.
Parse inner attributes on inline const block - #94985
Merged
Merged
Conversation
rust-highfive
commented
Mar 16, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
11 tasks
michaelwoerister
commented
Mar 16, 2022
Member
I don't feel qualified to review this. r? @pnkfelix, who's also on the lang team. |
pnkfelix
commented
Apr 14, 2022
Contributor
Okay, since inline const blocks are themselves already feature-gated, I'm comfortable approving this without going through full T-lang FCP process. |
pnkfelix
commented
Apr 14, 2022
Contributor
@bors r+ rollup |
bors
commented
Apr 14, 2022
Collaborator
📌 Commit f427698 has been approved by |
fee1-dead added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#94985 (Parse inner attributes on inline const block) - rust-lang#95006 (Reject `#[thread_local]` attribute on non-static items) - rust-lang#95426 (Include Refs in Valtree Creation) - rust-lang#95908 (Inline `shallow_resolve_ty` into `ShallowResolver`) - rust-lang#96058 (separate flock implementations into separate modules) - rust-lang#96088 (Update mdbook) - rust-lang#96118 (rustdoc: Rename `def_id` into `item_id` when the type is `ItemId` for readability) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #84414 (comment), inner attributes are intended to be supported "in all containers for statements (or some subset of statements)".
This PR adds inner attribute parsing and pretty-printing for inline const blocks (#76001), which contain statements just like an unsafe block or a loop body.