Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #94987
Merged
Merged
Conversation
Only look for complete suffixes or prefixes of irrefutable let patterns, so that an irrefutable let pattern in a chain surrounded by refutable ones is not linted, as it is an useful pattern.
Format core and std macro rules, removing needless surrounding blocks Many of the asserting and printing macros in `core` and `std` are written with prehistoric-looking formatting, like this: https://github.com/rust-lang/rust/blob/335ffbfa547df94ac236f5c56130cecf99c8d82b/library/std/src/macros.rs#L96-L101 In modern Rust style this would conventionally be written as follows instead, always using braces and a trailing semicolon on the macro arms: https://github.com/rust-lang/rust/blob/af53809c874e0afb7be966df4d3cfcaa05277c53/library/std/src/macros.rs#L98-L105 Getting rid of the unneeded braces inside the expansion reduces extraneous indentation in macro-expanded code. For example: ```rust println!("repro {}", true); ``` ```rust // before: { ::std::io::_print( ::core::fmt::Arguments::new_v1( &["repro ", "\n"], &[::core::fmt::ArgumentV1::new_display(&true)], ), ); }; ``` ```rust // after: ::std::io::_print( ::core::fmt::Arguments::new_v1( &["repro ", "\n"], &[::core::fmt::ArgumentV1::new_display(&true)], ), ); ```
…s, r=estebank Extend the irrefutable_let_patterns lint to let chains Implements the suggestion from rust-lang#94927 (comment) We only look for complete suffixes or prefixes of irrefutable let patterns, so that an irrefutable let pattern in a chain surrounded by refutable ones is not linted, as it is an useful pattern that has no low-cost replacement (unlike suffixes or prefixes which can just be copied outside of the `if`: either into the `if`'s block, or the block surrounding the `if`). If all patterns in a let chain are irrefutable, we lint as well. Depends on rust-lang#94958 ~~so I included it into the PR for now~~ *which has been merged since*. r? `@estebank` cc `@joshtriplett` `@c410-f3r`
…rustc-parse, r=Dylan-DPC Refactor: Use `format_args_capture` in some parts of `rustc_parse`
… r=Dylan-DPC Improve the explanation about the behaviour of read_line Close issue like rust-lang/book#2574
…et-else, r=joshtriplett Ensure that `let_else` does not interact with `let_chains` As requested on rust-lang#94927. cc `@joshtriplett` `@estebank`
Dylan-DPC
commented
Mar 16, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Mar 16, 2022
Collaborator
📌 Commit aaf2255 has been approved by |
bors
commented
Mar 16, 2022
Collaborator
bors
commented
Mar 16, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Mar 16, 2022
Collaborator
Finished benchmarking commit (a2af9cf): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
format_args_capturein some parts ofrustc_parse#94955 (Refactor: Useformat_args_capturein some parts ofrustc_parse)let_elsedoes not interact withlet_chains#94974 (Ensure thatlet_elsedoes not interact withlet_chains)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup