Uh oh!
There was an error while loading. Please reload this page.
Add use of bool::then in sys/unix/process - #95058
Merged
Merged
Conversation
Remove else { None } in favor of using bool::then()rust-highfive
commented
Mar 17, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
dtolnay
commented
Mar 18, 2022
Member
@bors r+ rollup |
bors
commented
Mar 18, 2022
Collaborator
📌 Commit b1f3179 has been approved by |
joshtriplett
commented
Mar 18, 2022
Member
Could you please check how this affects codegen? I expect it to produce effectively the same code, but I would like to make sure. |
wcampbell0x2a
commented
Mar 18, 2022
ContributorAuthor
Never done that but willing to learn it. What commands do I run for that? |
dtolnay
commented
Mar 18, 2022
Member
Identical according to https://rust.godbolt.org/z/TY5Y39fxr. |
wcampbell0x2a
commented
Mar 18, 2022
ContributorAuthor
sweet |
joshtriplett
commented
Mar 18, 2022
Member
@bors r+ |
bors
commented
Mar 18, 2022
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Mar 18, 2022
Collaborator
📌 Commit b1f3179 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#94115 (Let `try_collect` take advantage of `try_fold` overrides) - rust-lang#94295 (Always evaluate all cfg predicate in all() and any()) - rust-lang#94848 (Compare installed browser-ui-test version to the one used in CI) - rust-lang#94993 (Add test for >65535 hashes in lexing raw string) - rust-lang#95017 (Derive Eq for std::cmp::Ordering, instead of using manual impl.) - rust-lang#95058 (Add use of bool::then in sys/unix/process) - rust-lang#95083 (Document that `Option<extern "abi" fn>` discriminant elision applies for any ABI) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
else { None }in favor of usingbool::then()