Skip to content

Re-enable parallel debuginfo tests - #95072

Merged
bors merged 1 commit into
rust-lang:masterfrom
tromey:parallel-debug-tests
Mar 19, 2022
Merged

Re-enable parallel debuginfo tests#95072
bors merged 1 commit into
rust-lang:masterfrom
tromey:parallel-debug-tests

Conversation

@tromey

Copy link
Copy Markdown
Contributor

Debuginfo tests are serialized due to some older version of LLDB.
However, that comment was last touched in 2014, so presumably these
older versions are long since obsolete.

Partially fixes bug #72719.

Debuginfo tests are serialized due to some older version of LLDB.
However, that comment was last touched in 2014, so presumably these
older versions are long since obsolete.
Partially fixes bug rust-lang#72719.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
@tmiasko

Copy link
Copy Markdown
Contributor

Locally works reliably for me with lldb version 13 & gdb 10. Let's see what CI has to say about that.

@bors r+

@bors

bors commented Mar 18, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 05e9fcb has been approved by tmiasko

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 18, 2022
Re-enable parallel debuginfo tests
Debuginfo tests are serialized due to some older version of LLDB.
However, that comment was last touched in 2014, so presumably these
older versions are long since obsolete.
Partially fixes bug rust-lang#72719.
@Dylan-DPCDylan-DPC mentioned this pull request Mar 18, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Mar 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#93858 (Add a `process_group` method to UNIX `CommandExt`)
- rust-lang#94650 (Relax tests for Windows dos device names)
- rust-lang#94991 (Make Weak::new const)
- rust-lang#95072 (Re-enable parallel debuginfo tests)
- rust-lang#95109 (Extend --check-cfg tests to all predicate inside all/any)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7de48ea into rust-lang:masterMar 19, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 19, 2022
@tromey
tromey deleted the parallel-debug-tests branch March 19, 2022 19:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tromey@rust-highfive@tmiasko@bors@Mark-Simulacrum@rustbot