Skip to content

Fix perf issue for auto trait selection - #95333

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:auto-trait-perf-issue
Mar 28, 2022
Merged

Fix perf issue for auto trait selection#95333
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:auto-trait-perf-issue

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Mar 26, 2022

Copy link
Copy Markdown
Member

Follow-up of #95069 which fixes the perf issue introduced by it.

r? @oli-obk

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 26, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2022
@GuillaumeGomezGuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 26, 2022
@GuillaumeGomez

GuillaumeGomez commented Mar 26, 2022

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 26, 2022
@bors

bors commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ad88732 with merge 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b...

oli-obk
oli-obk reviewed Mar 26, 2022
View reviewed changes
Comment threadcompiler/rustc_trait_selection/src/traits/select/mod.rs
@bors

bors commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b (9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b)

@rust-timer

rust-timer commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator

Queued 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b with parent bc881e8, future comparison URL.

@GuillaumeGomez

GuillaumeGomez commented Mar 27, 2022

Copy link
Copy Markdown
MemberAuthor

Let's run another perf check to see if there is any difference with one field removed.

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors

bors commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit bd51f17 with merge 00ed864234397653296be8e49cfa858c092ccd63...

@bors

bors commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 00ed864234397653296be8e49cfa858c092ccd63 (00ed864234397653296be8e49cfa858c092ccd63)

@rust-timer

rust-timer commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b): comparison url.

Summary: This benchmark run shows 22 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -2.9%
  • Largest improvement in instruction counts: -10.2% on full builds of cargo-0.60.0 doc

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2022
@oli-obk

oli-obk commented Mar 27, 2022

Copy link
Copy Markdown
Contributor

@bors r+ rollup=never

@bors

bors commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit bd51f17 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2022
@bors

bors commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit bd51f17 with merge 3badf5c...

@bors

bors commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 3badf5c to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2022
@bors
bors merged commit 3badf5c into rust-lang:masterMar 28, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 28, 2022
@borsbors mentioned this pull request Mar 28, 2022
Closed
@GuillaumeGomez
GuillaumeGomez deleted the auto-trait-perf-issue branch March 28, 2022 08:24
@rust-timer

rust-timer commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3badf5c): comparison url.

Summary: This benchmark run shows 20 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -3.1%
  • Largest improvement in instruction counts: -10.1% on full builds of cargo-0.60.0 doc

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@AlexendooAlexendoo mentioned this pull request Mar 30, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@oli-obkoli-obk

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-timer@bors@oli-obk@rust-highfive@rustbot