Uh oh!
There was an error while loading. Please reload this page.
std: Stabilize feature try_reserve_2 - #95392
Merged
Merged
Conversation
rust-highfive
commented
Mar 28, 2022
Contributor
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
Xuanwo
commented
Mar 28, 2022
ContributorAuthor
@rustbot modify labels: +T-libs-api |
Xuanwo
commented
Mar 28, 2022
ContributorAuthor
r? @dtolnay |
Xuanwoforce-pushed
the
stablize_try_reserve_2
branch
from
March 28, 2022 02:02
254d06c to
5b68504Compare
This was referenced Mar 28, 2022
dtolnay
requested changes
Mar 28, 2022
dtolnay
left a comment
Member
There was a problem hiding this comment.
Please do the stabilization of new APIs in a different PR than the new capacity-related guarantees. They will need two different libs-api FCP.
Xuanwoforce-pushed
the
stablize_try_reserve_2
branch
from
March 28, 2022 02:24
5b68504 to
8d71a8dCompareXuanwo
commented
Mar 28, 2022
ContributorAuthor
Updated. |
dtolnay
commented
Mar 28, 2022
Member
This is blocked on the FCP in #91789 (comment). @rustbot label -S-waiting-on-author +S-blocked |
dtolnay
removed their request for review
April 20, 2022 02:53
Xuanwoforce-pushed
the
stablize_try_reserve_2
branch
from
June 16, 2022 01:29
8d71a8d to
5d4b203CompareSigned-off-by: Xuanwo <github@xuanwo.io>
Xuanwoforce-pushed
the
stablize_try_reserve_2
branch
from
June 16, 2022 01:30
5d4b203 to
324286fComparedtolnay
approved these changes
Jun 17, 2022
dtolnay
commented
Jun 17, 2022
Member
@bors r+ |
bors
commented
Jun 17, 2022
Collaborator
📌 Commit 324286f has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#95392 (std: Stabilize feature try_reserve_2 ) - rust-lang#97798 (Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown) - rust-lang#97844 (Windows: No panic if function not (yet) available) - rust-lang#98013 (Subtype FRU fields first in `type_changing_struct_update`) - rust-lang#98191 (Remove the rest of unnecessary `to_string`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to stabilize feature
try_reserve_2, closes#91789This PR will also replace the previous PR: #95139