Make def names and HIR names consistent. by cjgillot · Pull Request #95435 · rust-lang/rust

cjgillot · 2022-03-29T16:33:00Z

The name in the DefKey is interned to create the DefId, so it does not
require any query to access. This can be leveraged to avoid a few useless
HIR accesses for names.

In order to achieve that, generic parameters created from universal
impl-trait are given the pretty-printed ast as a name, instead of
{{opaque}}.

Drive-by: the TyCtxt::opt_item_name used a dummy span for non-local
definitions. We have access to def_ident_span, so we use it.

rust-highfive · 2022-03-29T16:33:03Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

cjgillot · 2022-03-29T17:11:20Z

@bors try @rust-timer queue

rust-timer · 2022-03-29T17:11:21Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-03-29T17:11:29Z

⌛ Trying commit 79010104f47e9a435ef49a7f4b40f0f84a56dda5 with merge 570bb0da8027dcda69858fc2b200800fd580563c...

bors · 2022-03-29T19:51:56Z

☀️ Try build successful - checks-actions
Build commit: 570bb0da8027dcda69858fc2b200800fd580563c (570bb0da8027dcda69858fc2b200800fd580563c)

rust-timer · 2022-03-29T19:51:57Z

Queued 570bb0da8027dcda69858fc2b200800fd580563c with parent 11909e3, future comparison URL.

rust-timer · 2022-03-29T23:52:22Z

Finished benchmarking commit (570bb0da8027dcda69858fc2b200800fd580563c): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

cjgillot · 2022-03-30T18:04:09Z

@bors try @rust-timer queue

rust-timer · 2022-03-30T18:04:11Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-03-30T18:04:22Z

⌛ Trying commit e71dc40236621ccbdb1ba6cea4aab5a6ccb3d2c8 with merge b3ca67599d9fad163470e4584416fc676a8fb6a9...

bors · 2022-03-30T19:25:39Z

☀️ Try build successful - checks-actions
Build commit: b3ca67599d9fad163470e4584416fc676a8fb6a9 (b3ca67599d9fad163470e4584416fc676a8fb6a9)

rust-timer · 2022-03-30T19:25:40Z

Queued b3ca67599d9fad163470e4584416fc676a8fb6a9 with parent 3e75146, future comparison URL.

rust-timer · 2022-03-30T21:22:53Z

Finished benchmarking commit (b3ca67599d9fad163470e4584416fc676a8fb6a9): comparison url.

Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

oli-obk · 2022-04-03T06:28:18Z

r? @oli-obk

oli-obk

I'll look into compiletest changes next week. I wanted to add a way to add defaults for the comment-configs of ui tests anyway, and we could use that to insert a filter for all crates.io crate paths

bors · 2022-04-05T12:51:54Z

☔ The latest upstream changes (presumably #95667) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2022-04-09T18:39:20Z

@bors r+

bors · 2022-04-09T18:39:22Z

📌 Commit 672ce15 has been approved by oli-obk

bors · 2022-04-09T22:48:03Z

⌛ Testing commit 672ce15 with merge 559c019...

bors · 2022-04-10T01:17:27Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 559c019 to master...

rust-timer · 2022-04-10T02:31:18Z

This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Avoid accessing HIR from MIR passes `hir_owner_nodes` contains a lot of information, and the query result is typically dirty. This forces dependent queries to be re-executed needlessly. This PR refactors some accesses to HIR to go through more targeted queries that yield the same result. Based on rust-lang#95435 and rust-lang#95436

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 29, 2022

rust-highfive assigned estebank Mar 29, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2022

cjgillot force-pushed the one-name branch from 95bb4d7 to 7901010Compare March 29, 2022 16:48

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 29, 2022

cjgillot force-pushed the one-name branch from 7901010 to e4a49bcCompare March 29, 2022 21:47

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 29, 2022

cjgillot force-pushed the one-name branch from e4a49bc to e71dc40Compare March 30, 2022 15:01

cjgillot mentioned this pull request Mar 30, 2022
Avoid accessing HIR from MIR passes #95487
Merged

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 30, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 30, 2022

cjgillot force-pushed the one-name branch from e71dc40 to 0173656Compare March 31, 2022 15:05

cjgillot commented Mar 31, 2022
View reviewed changes

Comment threadsrc/test/ui/issues/issue-21763.stderr Outdated

rust-highfive assigned oli-obk and unassigned estebank Apr 3, 2022

oli-obk requested changes Apr 3, 2022
View reviewed changes

Comment threadcompiler/rustc_resolve/src/def_collector.rs Outdated
Comment threadsrc/test/ui/associated-type-bounds/assoc-type-eq-with-dyn-atb-fail.stderr Outdated

cjgillot added 3 commits April 7, 2022 22:30

Compute ty_param_owner using DefIdTree.
b5dfa6a

Use def_key in tcx.item_name when possible.
f89d64d

Bless tests.
672ce15

cjgillot force-pushed the one-name branch from 0173656 to 672ce15Compare April 9, 2022 10:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2022

bors merged commit 559c019 into rust-lang:masterApr 10, 2022

rustbot added this to the 1.62.0 milestone Apr 10, 2022

klensy mentioned this pull request Apr 10, 2022
Restore link to perf run results in non relevant runs rust-lang/rustc-perf#1289
Closed

cjgillot deleted the one-name branch April 10, 2022 11:07

Uh oh!

Uh oh!

Conversation

cjgillot commented Mar 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 29, 2022

Uh oh!

This comment has been minimized.

cjgillot commented Mar 29, 2022

Uh oh!

rust-timer commented Mar 29, 2022

Uh oh!

bors commented Mar 29, 2022

Uh oh!

bors commented Mar 29, 2022

Uh oh!

rust-timer commented Mar 29, 2022

Uh oh!

rust-timer commented Mar 29, 2022

Uh oh!

cjgillot commented Mar 30, 2022

Uh oh!

rust-timer commented Mar 30, 2022

Uh oh!

bors commented Mar 30, 2022

Uh oh!

bors commented Mar 30, 2022

Uh oh!

rust-timer commented Mar 30, 2022

Uh oh!

rust-timer commented Mar 30, 2022

Uh oh!

Uh oh!

oli-obk commented Apr 3, 2022

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bors commented Apr 5, 2022

Uh oh!

oli-obk commented Apr 9, 2022

Uh oh!

bors commented Apr 9, 2022

Uh oh!

bors commented Apr 9, 2022

Uh oh!

bors commented Apr 10, 2022

Uh oh!

rust-timer commented Apr 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cjgillot commented Mar 29, 2022•
edited
Loading