Uh oh!
There was an error while loading. Please reload this page.
Windows: Synchronize asynchronous pipe reads and writes - #95467
Merged
Conversation
rust-highfive
commented
Mar 30, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
ChrisDentonforce-pushed
the
async-read-pipe
branch
from
March 30, 2022 10:20
963e1ff to
5475047CompareUh oh!
There was an error while loading. Please reload this page.
joshtriplett
commented
Apr 4, 2022
Member
@bors r+ |
bors
commented
Apr 4, 2022
Collaborator
📌 Commit 62f37da has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 4, 2022
…triplett Windows: Synchronize asynchronous pipe reads and writes On Windows, the pipes used for spawned processes are opened for asynchronous access but `read` and `write` are done using the standard methods that assume synchronous access. This means that the buffer (and variables on the stack) may be read/written to after the function returns. This PR ensures reads/writes complete before returning. Note that this only applies to pipes we create and does not affect the standard file read/write methods. Fixesrust-lang#95411
Dylan-DPC
commented
Apr 4, 2022
Member
@bors r=joshtriplett |
bors
commented
Apr 4, 2022
Collaborator
📌 Commit cbbcd87 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#92942 (stabilize windows_process_extensions_raw_arg) - rust-lang#94817 (Release notes for 1.60.0) - rust-lang#95343 (Reduce unnecessary escaping in proc_macro::Literal::character/string) - rust-lang#95431 (Stabilize total_cmp) - rust-lang#95438 (Add SyncUnsafeCell.) - rust-lang#95467 (Windows: Synchronize asynchronous pipe reads and writes) - rust-lang#95609 (Suggest borrowing when trying to coerce unsized type into `dyn Trait`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the pipes used for spawned processes are opened for asynchronous access but
readandwriteare done using the standard methods that assume synchronous access. This means that the buffer (and variables on the stack) may be read/written to after the function returns.This PR ensures reads/writes complete before returning. Note that this only applies to pipes we create and does not affect the standard file read/write methods.
Fixes#95411