Skip to content

Add note to the move size diagnostic - #95478

Merged
bors merged 1 commit into
masterfrom
unknown repository
Mar 31, 2022
Merged

Add note to the move size diagnostic#95478
bors merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 30, 2022•
edited by Dylan-DPC
Loading

Copy link
Copy Markdown

context: #83518

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 30, 2022
@rust-highfive

rust-highfive commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@ghost

ghost commented Mar 30, 2022•
edited by ghost
Loading

Copy link
Copy Markdown
Author

Resolves one tick on #83518

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ghost

ghost commented Mar 30, 2022

Copy link
Copy Markdown
Author

@Dylan-DPC Sorry, I don't understand why you edited this PR's description

compiler-errors
compiler-errors reviewed Mar 30, 2022
View reviewed changes
Comment threadcompiler/rustc_monomorphize/src/collector.rs Outdated
@compiler-errors

compiler-errors commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Can you bless the tests again? -- CI is going to fail since stderr is not updated on those. And please squash the commits into one, thanks!

compiler-errors
compiler-errors reviewed Mar 30, 2022
View reviewed changes
Comment threadcompiler/rustc_monomorphize/src/collector.rs Outdated
@ghost

ghost commented Mar 30, 2022

Copy link
Copy Markdown
Author

Can you bless the tests again? -- CI is going to fail since stderr is not updated on those. And please squash the commits into one, thanks!

The entirety of the commits or just these two ?

@compiler-errors

compiler-errors commented Mar 30, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

All of them, please. No need to have 5 commits for a PR that changes 3 files 😆 Thanks!

@compiler-errors

compiler-errors commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Thanks a bunch.

r? @compiler-errors
@bors r+ rollup=always

@bors

bors commented Mar 30, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d65b9a1 has been approved by compiler-errors

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@Dylan-DPC

Dylan-DPC commented Mar 30, 2022

Copy link
Copy Markdown
Member

@Dylan-DPC Sorry, I don't understand why you edited this PR's description

Just added the issue number to the top comment so it's easier to view in future

@Dylan-DPCDylan-DPC mentioned this pull request Mar 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2022
@bors
Auto merge ofrust-lang#95511- Dylan-DPC:rollup-4n880fd, r=Dylan-DPC
0331491
Rollup of 5 pull requests
Successful merges:
- rust-lang#95445 (Don't build the full compiler before running unit tests)
- rust-lang#95470 (Fix last rustdoc-gui spurious test)
- rust-lang#95478 (Add note to the move size diagnostic)
- rust-lang#95495 (Remove unneeded `to_string` call)
- rust-lang#95505 (Fix library/std compilation on openbsd.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4388ac5 into rust-lang:masterMar 31, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 31, 2022
@ghostghost mentioned this pull request Apr 2, 2022
Open
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

7 participants

@rust-highfive@rust-log-analyzer@compiler-errors@bors@Dylan-DPC@nagisa@rustbot