Uh oh!
There was an error while loading. Please reload this page.
interpret: remove MemoryExtra in favor of giving access to the Machine - #95620
Merged
Conversation
rust-highfive
commented
Apr 3, 2022
Contributor
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
oli-obk
approved these changes
Apr 3, 2022
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
Some of these changes make it very clear that this is the right way forward imo.
I still want to look over the miri changes though I don't expect anything deal breaking
RalfJung
commented
Apr 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Apr 4, 2022
Contributor
@bors r+ |
bors
commented
Apr 4, 2022
Collaborator
📌 Commit 84a343d has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 4, 2022
interpret: remove MemoryExtra in favor of giving access to the Machine The Miri PR for this is upcoming. r? `@oli-obk`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#91873 (Mention implementers of unsatisfied trait) - rust-lang#95588 (explicitly distinguish pointer::addr and pointer::expose_addr) - rust-lang#95603 (Fix late-bound ICE in `dyn` return type suggestion) - rust-lang#95620 (interpret: remove MemoryExtra in favor of giving access to the Machine) - rust-lang#95630 (Update `NonNull` pointer provenance methods' documentation) - rust-lang#95631 (Refactor: remove unnecessary nested blocks) - rust-lang#95642 (`CandidateSource::XCandidate` -> `CandidateSource::X`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang/miri
that referenced
this pull request
Apr 5, 2022
adjust for MemoryExtra being merged into Machine The Miri side of rust-lang/rust#95620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Miri PR for this is upcoming.
r? @oli-obk