Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #95666
Closed
Dylan-DPC wants to merge 20 commits into
Closed
Conversation
Per https://www.freedesktop.org/software/systemd/man/os-release.html, > Variable assignment values must be enclosed in double or single quotes > if they include spaces, semicolons or other special characters outside > of A–Z, a–z, 0–9. (Assignments that do not include these special > characters may be enclosed in quotes too, but this is optional.) So, past `ID=nixos`, let's also check for `ID='nixos'` and `ID="nixos"`. One of these is necessary between NixOS/nixpkgs#162168 and NixOS/nixpkgs#164068, but this seems more correct either way.
Eric figured out the fix to this almost 2 years ago, I just didn't read his comment carefully enough at the timme. The issue was that fake rustc and fake rustdoc were inconsistent about when they passed `--sysroot` to the real compiler. Change them to consistently only pass it when `--target` is present.
… for a private module
bootstrap.py: nixos check in /etc/os-release with quotes Per https://www.freedesktop.org/software/systemd/man/os-release.html, > Variable assignment values must be enclosed in double or single quotes > if they include spaces, semicolons or other special characters outside > of A–Z, a–z, 0–9. (Assignments that do not include these special > characters may be enclosed in quotes too, but this is optional.) So, past `ID=nixos`, let's also check for `ID='nixos'` and `ID="nixos"`. One of these is necessary between NixOS/nixpkgs#162168 and NixOS/nixpkgs#164068, but this seems more correct either way.
Fix `x doc --stage 0 compiler` Eric figured out the fix to this almost 2 years ago, I just didn't read his comment carefully enough at the timme. The issue was that fake rustc and fake rustdoc were inconsistent about when they passed `--sysroot` to the real compiler. Change them to consistently only pass it when `--target` is present. cc rust-lang#74976 (comment)Fixesrust-lang#79980 r? `@ehuss`
…77, r=compiler-errors Suggest derivable trait on E0277 error Closesrust-lang#95099 .
…n1011 Note invariance reason for FnDef types Fixesrust-lang#95272. Is it worthwhile even printing a variance explanation here? Or should I try to track down which function parameter is responsible for the invariance? r? `@Aaron1011` since you wrote rust-lang#89336
…raits-in-scope-primitive, r=jyn514 Fix intra doc link ICE when trying to get traits in scope for primitive Fixesrust-lang#95633. I think `@notriddle` was the one who worked on this part of the code last so: r? `@notriddle`
…davidtwco diagnostics: use correct span for const generics Fixesrust-lang#95616
Rely on #[link] attribute for unwind on Fuchsia. Closesrust-lang#95575.
Update panic docs to make it clearer when to use panic vs Result This is based on a question that came up in one of my [error handling office hours](https://twitter.com/yaahc_/status/1506376624509374467?s=20&t=Sp-cEjrx5kpMdNsAGPOo9w) meetings. I had a user who was fairly familiar with error type design, thiserror and anyhow, and rust in general, but who was still confused about when to use panics vs when to use Result and `Error`. This will also be cross referenced in an error handling FAQ that I will be creating in the https://github.com/rust-lang/project-error-handling repo shortly.
Dylan-DPC
commented
Apr 5, 2022
MemberAuthor
@bors p=5 rollup=never |
Dylan-DPC
commented
Apr 5, 2022
MemberAuthor
@bors r+ |
bors
commented
Apr 5, 2022
Collaborator
📌 Commit 87836c5 has been approved by |
bors
commented
Apr 5, 2022
Collaborator
⌛ Testing commit 87836c5 with merge 40de905dd5d504b2e20d150e2fa0d1e9f3a0f503... |
rust-log-analyzer
commented
Apr 5, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Apr 5, 2022
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x doc --stage 0 compiler#95449 (Fixx doc --stage 0 compiler)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup