Rollup of 6 pull requests by Dylan-DPC · Pull Request #95675 · rust-lang/rust

Dylan-DPC · 2022-04-05T12:20:55Z

Successful merges:

Suggest derivable trait on E0277 error #95525 (Suggest derivable trait on E0277 error)
diagnostics: use correct span for const generics #95654 (diagnostics: use correct span for const generics)
Rely on #[link] attribute for unwind on Fuchsia. #95659 (Rely on #[link] attribute for unwind on Fuchsia.)
Update panic docs to make it clearer when to use panic vs Result #95660 (Update panic docs to make it clearer when to use panic vs Result)
Refactor: remove unused function parameters #95670 (Refactor: remove unused function parameters)
⬆️ rust-analyzer #95673 (:arrow_up: rust-analyzer)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Fixesrust-lang#95616

Closesrust-lang#95575.

…s self

…77, r=compiler-errors Suggest derivable trait on E0277 error Closesrust-lang#95099 .

…davidtwco diagnostics: use correct span for const generics Fixesrust-lang#95616

Rely on #[link] attribute for unwind on Fuchsia. Closesrust-lang#95575.

Update panic docs to make it clearer when to use panic vs Result This is based on a question that came up in one of my [error handling office hours](https://twitter.com/yaahc_/status/1506376624509374467?s=20&t=Sp-cEjrx5kpMdNsAGPOo9w) meetings. I had a user who was fairly familiar with error type design, thiserror and anyhow, and rust in general, but who was still confused about when to use panics vs when to use Result and `Error`. This will also be cross referenced in an error handling FAQ that I will be creating in the https://github.com/rust-lang/project-error-handling repo shortly.

…meters, r=davidtwco Refactor: remove unused function parameters

…=lnicola ⬆️ rust-analyzer r? `@ghost`

Dylan-DPC · 2022-04-05T12:21:05Z

@bors r+ rollup=never p=5

bors · 2022-04-05T12:21:07Z

📌 Commit 73a8f95 has been approved by Dylan-DPC

bors · 2022-04-05T12:21:34Z

⌛ Testing commit 73a8f95 with merge 8537ba5b8c32aa1c136e3b9fc3a73637640cf6d3...

bors · 2022-04-05T12:50:41Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-04-05T13:29:54Z

The job wasm32 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [ui] ui/invalid/invalid-llvm-passes.rs stdout ----
diff of stderr:
1 error: failed to run LLVM passes: unknown pass name 'unknown-pass'
+ thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
+ left: `LLVMing`,
+ left: `LLVMing`,
+ right: `Codegenning`', /checkout/compiler/rustc_codegen_ssa/src/back/write.rs:1471:21
+ 0: 0x7f3d7fce478d - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h59ae1a7b22004c8c
+ 0: 0x7f3d7fce478d - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h59ae1a7b22004c8c
+ 1: 0x7f3d7fd47a38 - core::fmt::write::ha7e7cf912fe9539a
+ 2: 0x7f3d7fcd5711 - std::io::Write::write_fmt::h5510ee268d07df7b
+ 3: 0x7f3d7fce45ab - std::sys_common::backtrace::print::h08bb60edf9be83f1
+ 4: 0x7f3d7fce7f24 - std::panicking::default_hook::{{closure}}::h3ffc2d123ec2b8d5
+ 5: 0x7f3d7fce7b9c - std::panicking::default_hook::h2e979a8c86f0f0bf
+ 6: 0x7f3d80e65a1a - rustc_driver[68b56281aac6e522]::DEFAULT_HOOK::{closure#0}::{closure#0}
+ 7: 0x7f3d7fce85fa - std::panicking::rust_panic_with_hook::h6d85312f2998bd9b
+ 8: 0x7f3d7fce8427 - std::panicking::begin_panic_handler::{{closure}}::h656f29de7596b1f2
+ 9: 0x7f3d7fce4cc4 - std::sys_common::backtrace::__rust_end_short_backtrace::hd163467b5b5c7a90
+ 10: 0x7f3d7fce8119 - rust_begin_unwind
+ 11: 0x7f3d7fc9cbb3 - core::panicking::panic_fmt::hb65d42c9d8beea97
+ 12: 0x7f3d7fd444e8 - core::panicking::assert_failed_inner::hb5765767a3717cf6
+ 13: 0x7f3d809d85fb - core[7aa401e17aad33d1]::panicking::assert_failed::<rustc_codegen_ssa[9a695caeb5983c6]::back::write::MainThreadWorkerState, rustc_codegen_ssa[9a695caeb5983c6]::back::write::MainThreadWorkerState>
+ 14: 0x7f3d8105f7db - rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work::<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}
+ 15: 0x7f3d8105adc6 - std[a46efefb3fd5620c]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend as rustc_codegen_ssa[9a695caeb5983c6]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#0}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>
+ 16: 0x7f3d811d3749 - <<std[a46efefb3fd5620c]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend as rustc_codegen_ssa[9a695caeb5983c6]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#0}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#1} as core[7aa401e17aad33d1]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
+ 17: 0x7f3d7fcf4503 - std::sys::unix::thread::Thread::new::thread_start::h0e3ab9d360f09880
+ 18: 0x7f3d7fa1c609 - start_thread
+ 19: 0x7f3d7fb5c163 - clone
+ 20: 0x0 - <unknown>
+ error: internal compiler error: unexpected panic
+ + note: the compiler unexpectedly panicked. this is a bug.
+ + + note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
+ + note: rustc 1.62.0-nightly (8537ba5b8 2022-04-05) running on x86_64-unknown-linux-gnu
+ + note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C prefer-dynamic -C rpath -C debuginfo=0 -C passes=unknown-pass -Z new-llvm-pass-manager=yes
+ query stack during panic:
+ end of query stack
3 error: aborting due to previous error
4 ---
To only update this specific test, also pass `--test-args invalid/invalid-llvm-passes.rs`
error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/invalid/invalid-llvm-passes.rs" "-Zthreads=1" "--target=wasm32-unknown-emscripten" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-unknown-emscripten/native/rust-test-helpers" "-Cpasses=unknown-pass" "-Z" "new-llvm-pass-manager=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes/auxiliary"
stdout: none
--- stderr -------------------------------
error: failed to run LLVM passes: unknown pass name 'unknown-pass'
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
left: `LLVMing`,
left: `LLVMing`,
right: `Codegenning`', /checkout/compiler/rustc_codegen_ssa/src/back/write.rs:1471:21
0: 0x7f3d7fce478d - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h59ae1a7b22004c8c
0: 0x7f3d7fce478d - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h59ae1a7b22004c8c
1: 0x7f3d7fd47a38 - core::fmt::write::ha7e7cf912fe9539a
2: 0x7f3d7fcd5711 - std::io::Write::write_fmt::h5510ee268d07df7b
3: 0x7f3d7fce45ab - std::sys_common::backtrace::print::h08bb60edf9be83f1
4: 0x7f3d7fce7f24 - std::panicking::default_hook::{{closure}}::h3ffc2d123ec2b8d5
5: 0x7f3d7fce7b9c - std::panicking::default_hook::h2e979a8c86f0f0bf
6: 0x7f3d80e65a1a - rustc_driver[68b56281aac6e522]::DEFAULT_HOOK::{closure#0}::{closure#0}
7: 0x7f3d7fce85fa - std::panicking::rust_panic_with_hook::h6d85312f2998bd9b
8: 0x7f3d7fce8427 - std::panicking::begin_panic_handler::{{closure}}::h656f29de7596b1f2
9: 0x7f3d7fce4cc4 - std::sys_common::backtrace::__rust_end_short_backtrace::hd163467b5b5c7a90
10: 0x7f3d7fce8119 - rust_begin_unwind
11: 0x7f3d7fc9cbb3 - core::panicking::panic_fmt::hb65d42c9d8beea97
12: 0x7f3d7fd444e8 - core::panicking::assert_failed_inner::hb5765767a3717cf6
13: 0x7f3d809d85fb - core[7aa401e17aad33d1]::panicking::assert_failed::<rustc_codegen_ssa[9a695caeb5983c6]::back::write::MainThreadWorkerState, rustc_codegen_ssa[9a695caeb5983c6]::back::write::MainThreadWorkerState>
14: 0x7f3d8105f7db - rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work::<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}
15: 0x7f3d8105adc6 - std[a46efefb3fd5620c]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend as rustc_codegen_ssa[9a695caeb5983c6]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#0}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>
16: 0x7f3d811d3749 - <<std[a46efefb3fd5620c]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend as rustc_codegen_ssa[9a695caeb5983c6]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[9a695caeb5983c6]::back::write::start_executing_work<rustc_codegen_llvm[36f3397ee907c4b6]::LlvmCodegenBackend>::{closure#4}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#0}, core[7aa401e17aad33d1]::result::Result<rustc_codegen_ssa[9a695caeb5983c6]::back::write::CompiledModules, ()>>::{closure#1} as core[7aa401e17aad33d1]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
17: 0x7f3d7fcf4503 - std::sys::unix::thread::Thread::new::thread_start::h0e3ab9d360f09880
18: 0x7f3d7fa1c609 - start_thread
19: 0x7f3d7fb5c163 - clone
20: 0x0 - <unknown>
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.62.0-nightly (8537ba5b8 2022-04-05) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C prefer-dynamic -C rpath -C debuginfo=0 -C passes=unknown-pass -Z new-llvm-pass-manager=yes
query stack during panic:
end of query stack
error: aborting due to previous error
------------------------------------------

notriddleand others added 15 commits April 4, 2022 12:16

diagnostics: use correct span for const generics
6ece80f
Fixesrust-lang#95616

Rely on #[link] attribute for unwind on Fuchsia.
92246c0
Closesrust-lang#95575.

Update panic docs to make it clearer when to use panic vs Result
ccb704c

Suggest derivable trait on E0277
0d2a000

Suggest only when Rhs for PartialEq and PartialOrd is the same type a…
0ff2f58
…s self

Suggest only when all fields impl the trait
de23782

Fix ui test for nll
b831b60

remove unused function parameters
9759804

⬆️ rust-analyzer
505573e

Rollup merge ofrust-lang#95525- ohno418:suggest-derivable-trait-E02…
e028d93
…77, r=compiler-errors Suggest derivable trait on E0277 error Closesrust-lang#95099 .

Rollup merge ofrust-lang#95654- notriddle:notriddle/issue-95616, r=…
33b0fba
…davidtwco diagnostics: use correct span for const generics Fixesrust-lang#95616

Rollup merge ofrust-lang#95659- anp:remove-link-print, r=tmandry
cd7543f
Rely on #[link] attribute for unwind on Fuchsia. Closesrust-lang#95575.

Rollup merge ofrust-lang#95670- TaKO8Ki:remove-unused-function-para…
9711e9d
…meters, r=davidtwco Refactor: remove unused function parameters

Rollup merge ofrust-lang#95673- lnicola:rust-analyzer-2022-04-05, r…
73a8f95
…=lnicola ⬆️ rust-analyzer r? `@ghost`

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 5, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 5, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 5, 2022

Dylan-DPC mentioned this pull request Apr 5, 2022
failed to run LLVM passes: unknown pass name 'unknown-pass' #95679
Closed

Dylan-DPC closed this Apr 6, 2022

Dylan-DPC deleted the rollup-3fbqotx branch April 6, 2022 01:29

Navigation Menu

Uh oh!

Uh oh!

Rollup of 6 pull requests - #95675

Rollup of 6 pull requests#95675
Dylan-DPC wants to merge 15 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-3fbqotx

Dylan-DPC commented Apr 5, 2022

Uh oh!

Dylan-DPC commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

rust-log-analyzer commented Apr 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

Dylan-DPC commented Apr 5, 2022

Uh oh!

Dylan-DPC commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

bors commented Apr 5, 2022

Uh oh!

rust-log-analyzer commented Apr 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants