Reenable debuginfo tests by cbiffle · Pull Request #95696 · rust-lang/rust

cbiffle · 2022-04-05T19:37:09Z

These tests were disabled four years ago; it appears that it was
intended to be temporary.

In that time their assertions have rotted. I've gone through and fixed
the assertions where necessary and rehabilitated them. In several cases
I've had to leave lldb disabled, because the lldb output has changed in
ways that I don't understand. I figured gdb coverage was better than no
coverage.

It's worth noting that these tests being enabled would probably have
caught the regression observed in #90357.

Since September, the toolchain has not been generating reliable DWARF information for static variables when LTO is on. This has affected projects in the embedded space where the use of LTO is typical. In our case, it has kept us from bumping past the 2021-09-22 nightly toolchain lest our debugger break. This has been a pretty dramatic regression for people using debuggers and static variables. See rust-lang#90357 for more info and a repro case. This commit is a mechanical revert of d5de680 from PR rust-lang#89041, which caused the issue. (Note on that PR that the commit's author has requested it be reverted.) I have locally verified that this fixesrust-lang#90357 by restoring the functionality of both the repro case I posted on that bug, and debugger behavior on real programs. There do not appear to be test cases for this in the toolchain; if I've missed them, point me at 'em and I'll update them.

- Re-enabled basic-types-globals which has been disabled since 2018 - Updated its now-rotted assertions about GDB's output to pass - Rewrote header comment describing some previous state of GDB behavior that didn't match either the checked-in assertions _or_ the current behavior, and so I assume has just been wrong for some time. - Copy-pasta'd the test into a version that uses LTO to check for regression on rust-lang#90357, because I don't see a way to matrix the same test into several build configurations.

rust-highfive · 2022-04-05T19:37:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

cbiffle · 2022-04-05T19:47:40Z

(More context available in #95685, fwiw.)

cbiffle · 2022-04-05T19:54:30Z

Welp. One of these tests appears to segfault rustc under certain circumstances. Guess I'll turn it back off.

Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 136 tests
i........i..i..i.......ii.i........F......i.............iii....ii.......i.......i................... 100/136
Some tests failed in compiletest suite=debuginfo mode=debuginfo host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
..i.................................
failures:
---- [debuginfo-gdb] debuginfo/drop-locations.rs stdout ----
NOTE: compiletest thinks it is using GDB with native rust support
error: compilation failed!
status: signal: 11 (core dumped)
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/debuginfo/drop-locations.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/drop-locations.gdb/a" "-Crpath" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-g" "-O" "-C" "no-prepopulate-passes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/drop-locations.gdb/auxiliary"
stdout: none
stderr: none
failures:
[debuginfo-gdb] debuginfo/drop-locations.rs
test result: FAILED. 119 passed; 1 failed; 16 ignored; 0 measured; 0 filtered out; finished in 4.09s

These tests were disabled four years ago; it appears that it was intended to be temporary. In that time their assertions have rotted. I've gone through and fixed the assertions where necessary and rehabilitated them. In several cases I've had to leave lldb disabled, because the lldb output has changed in ways that I don't understand. I figured gdb coverage was better than no coverage. It's worth noting that these tests being enabled would probably have caught the regression observed in rust-lang#90357.

lcnr · 2022-04-12T10:42:31Z

hey 👋 is there anything to review right now? If so please comment r? rust-lang/compiler to reassign this PR as I don't know much about the state of debug info in Rust.

cbiffle · 2022-04-12T16:40:16Z

Sorry, this is based on another PR (#95685) that I thought was headed for review. Without it, the tests don't pass. I'll update when that's in.

wesleywiser · 2022-04-14T16:49:01Z

Oh, excellent! I started working on re-enabling many of these as well in #94489 but I haven't had much time lately to work on that. I'm happy to review & approve your changes instead!

r? @wesleywiser

cbiffle · 2022-04-14T17:59:27Z

Oh, excellent! I started working on re-enabling many of these as well in #94489 but I haven't had much time lately to work on that. I'm happy to review & approve your changes instead!
r? @wesleywiser

Thanks! The PR to fix the debuginfo generation has been approved, once that's rolled up I'll rebase this and set it to ready (and CC you).

camelid · 2022-08-02T21:21:16Z

triage: Hi @cbiffle, it looks like the fix PR you mentioned has been merged. Is this just in need of a rebase and review?

cbiffle · 2022-08-02T23:02:24Z

triage: Hi @cbiffle, it looks like the fix PR you mentioned has been merged. Is this just in need of a rebase and review?

Oh hi! Yes, I believe that is correct. Lemme set the ready bit.

camelid · 2022-08-03T00:06:10Z

Hi, I think this might need a rebase first! (Unless you feel that a review first would be helpful.)

Either way, please then post a comment with @rustbot ready to mark your PR as ready for a review. This changes the label, which is what reviewers usually look for.

JohnCSimon · 2022-09-11T05:46:17Z

Triage - doesn't seem to be in ready state? Not sure what's causing this

@cbiffle cbiffle marked this pull request as ready for review last month

@rustbot ready - setting it to ready anyway

rustbot · 2022-09-11T05:46:18Z

Error: The "Ready" shortcut only works on pull requests.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

JohnCSimon · 2022-09-11T05:47:49Z

???
@rustbot ready

ok, setting it manually and I'll follow up with #t-infra

rustbot · 2022-09-11T05:47:50Z

Error: The "Ready" shortcut only works on pull requests.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

wesleywiser · 2022-09-12T15:11:00Z

@cbiffle do you want rebase out 98190b7 since that was already merged in #95685?

apiraino · 2022-10-26T16:18:11Z

Switching to waiting on PR author if I read this comment correctly. @cbiffle Feel free to request a review with @rustbot ready, thanks!

@rustbot author

JohnCSimon · 2023-01-01T19:00:18Z

@cbiffle
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

cbiffle added 2 commits April 5, 2022 10:38

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2022

rust-highfive assigned lcnr Apr 5, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2022

cbiffle mentioned this pull request Apr 5, 2022
Revert "Work around invalid DWARF bugs for fat LTO" #95685
Merged

cbiffle force-pushed the reenable-debuginfo-tests branch from 664036d to d59a793Compare April 5, 2022 19:55

lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2022

rust-highfive assigned wesleywiser and unassigned lcnr Apr 14, 2022

cbiffle marked this pull request as ready for review August 2, 2022 23:02

wesleywiser mentioned this pull request Aug 15, 2022
lexical-scope-with-macro.rs failed on Xcode 9.3 #48807
Closed

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2022

JohnCSimon mentioned this pull request Sep 11, 2022
@rustbot ready and @rustbot author erroring out in a few cases rust-lang/triagebot#1651
Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2022

JohnCSimon closed this Jan 1, 2023

rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 1, 2023

Uh oh!

Uh oh!

Conversation

cbiffle commented Apr 5, 2022

Uh oh!

rust-highfive commented Apr 5, 2022

Uh oh!

cbiffle commented Apr 5, 2022

Uh oh!

cbiffle commented Apr 5, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr commented Apr 12, 2022

Uh oh!

cbiffle commented Apr 12, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleywiser commented Apr 14, 2022

Uh oh!

cbiffle commented Apr 14, 2022

Uh oh!

camelid commented Aug 2, 2022

Uh oh!

cbiffle commented Aug 2, 2022

Uh oh!

camelid commented Aug 3, 2022

Uh oh!

JohnCSimon commented Sep 11, 2022

Uh oh!

rustbot commented Sep 11, 2022

Uh oh!

JohnCSimon commented Sep 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 11, 2022

Uh oh!

wesleywiser commented Sep 12, 2022

Uh oh!

apiraino commented Oct 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JohnCSimon commented Jan 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cbiffle commented Apr 5, 2022•
edited
Loading

cbiffle commented Apr 12, 2022•
edited
Loading

JohnCSimon commented Sep 11, 2022•
edited
Loading

apiraino commented Oct 26, 2022•
edited
Loading