Remove `#[rustc_deprecated]` by jhpratt · Pull Request #95960 · rust-lang/rust

jhpratt · 2022-04-12T01:53:32Z

This removes #[rustc_deprecated] and introduces diagnostics to help users to the right direction (that being #[deprecated]). All uses of #[rustc_deprecated] have been converted. CI is expected to fail initially; this requires #95958, which includes converting stdarch.

I plan on following up in a short while (maybe a bootstrap cycle?) removing the diagnostics, as they're only intended to be short-term.

rust-highfive · 2022-04-12T01:53:35Z

Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary

rust-highfive · 2022-04-12T01:53:37Z

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

jhpratt · 2022-04-12T02:02:37Z

(that's the failure I was expecting)

jhpratt · 2022-04-14T05:18:59Z

CI is green, but I'd still like to make a few more changes before this should be merged.

@rustbot author

With the change to built-in duplicate checking, E0550 is no longer emitted.

jhpratt · 2022-04-15T03:30:38Z

After playing whack-a-mole with tests and running into a spurious error, CI is once again green. I'm happy with where this is now. Ready for review @joshtriplett!

@rustbot ready

wesleywiser · 2022-04-28T14:27:36Z

r? rust-lang/compiler

compiler-errors

Looks good to me

compiler-errors · 2022-05-09T03:04:36Z

@bors r+

bors · 2022-05-09T03:04:38Z

📌 Commit dac487a has been approved by compiler-errors

bors · 2022-05-09T04:47:34Z

⌛ Testing commit dac487a with merge 8a2fe75...

bors · 2022-05-09T07:05:12Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8a2fe75 to master...

rust-timer · 2022-05-09T08:22:39Z

Finished benchmarking commit (8a2fe75): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Remove handling of `#[rustc_deprecated]` This should be merged along with rust-lang/rust#95960. Because the attribute still exists in rustc, I've left the definition here. With that said, any use of it is an error, so I've removed any handling of `#[rustc_deprecated]`.

…compiler-errors Remove `rustc_deprecated` diagnostics Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust. `@rustbot` label +A-diagnostics r? `@compiler-errors`

…compiler-errors Remove `rustc_deprecated` diagnostics Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust. ``@rustbot`` label +A-diagnostics r? ``@compiler-errors``

rust-lang/rust#95960

See rust-lang/rust#95960

rust-highfive assigned joshtriplett Apr 12, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022

This comment was marked as resolved.
Sign in to view

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 12, 2022

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch from 0e02d43 to e2df4baCompare April 13, 2022 22:19

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch 2 times, most recently from fc4e862 to f81e20eCompare April 14, 2022 04:38

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2022

jhpratt added 2 commits April 14, 2022 01:33

Bump stdarch
8ff5e3c

Remove use of #[rustc_deprecated]
4fbe73e

jhpratt force-pushed the remove-rustc_deprecated branch from f81e20e to 7bc0b27Compare April 14, 2022 05:38

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch from 7bc0b27 to b95659dCompare April 14, 2022 05:59

This was referenced Apr 14, 2022
Update docs for deprecated attribute rust-lang/rustc-dev-guide#1338
Merged
Remove handling of #[rustc_deprecated]rust-lang/rust-analyzer#11983
Merged

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch from b95659d to d06891cCompare April 14, 2022 06:23

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch from d06891c to f2f52f6Compare April 14, 2022 06:45

This comment has been minimized.
Sign in to view

jhpratt force-pushed the remove-rustc_deprecated branch from 53108ab to 2ad699dCompare April 15, 2022 01:58

Add note to E0550
dac487a
With the change to built-in duplicate checking, E0550 is no longer emitted.

jhpratt force-pushed the remove-rustc_deprecated branch from 2ad699d to dac487aCompare April 15, 2022 02:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2022

rust-highfive assigned compiler-errors and unassigned joshtriplett Apr 28, 2022

compiler-errors approved these changes May 9, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2022

bors merged commit 8a2fe75 into rust-lang:masterMay 9, 2022

rustbot added this to the 1.62.0 milestone May 9, 2022

bors mentioned this pull request May 9, 2022
deprecate f{32,64}::DIGITS #89238
Closed

jhpratt deleted the remove-rustc_deprecated branch May 9, 2022 13:07

jhpratt mentioned this pull request Jun 14, 2022
Remove rustc_deprecated diagnostics #98115
Merged

est31 added a commit to est31/std-dev-guide that referenced this pull request Aug 23, 2022
rustc_deprecated got removed, now only deprecated is used
eca4207
rust-lang/rust#95960

est31 added a commit to est31/std-dev-guide that referenced this pull request Aug 23, 2022
rustc_deprecated got removed, now only deprecated is used
125fd7c
See rust-lang/rust#95960

est31 mentioned this pull request Aug 23, 2022
rustc_deprecated got removed, now only deprecated is used rust-lang/std-dev-guide#42
Merged

dtolnay mentioned this pull request Nov 21, 2022
Deprecate the unstable ptr_to_from_bits feature #95583
Merged

Uh oh!

Uh oh!

Conversation

jhpratt commented Apr 12, 2022

Uh oh!

rust-highfive commented Apr 12, 2022

Uh oh!

rust-highfive commented Apr 12, 2022

Uh oh!

This comment was marked as resolved.

jhpratt commented Apr 12, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

jhpratt commented Apr 14, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jhpratt commented Apr 15, 2022

Uh oh!

wesleywiser commented Apr 28, 2022

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

rust-timer commented May 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants