Uh oh!
There was an error while loading. Please reload this page.
prevent opaque types from appearing in impl headers - #95973
Merged
Conversation
rust-highfive
commented
Apr 12, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
lqd
reviewed
Apr 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
compiler-errors
approved these changes
Apr 12, 2022
compiler-errors
left a comment
Contributor
There was a problem hiding this comment.
r=me with mine and lqd's typo nits fixed, or not (they're insignificant anyways)
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
oli-obk
commented
Apr 12, 2022
ContributorAuthor
@bors r=compiler-errors |
bors
commented
Apr 12, 2022
Collaborator
📌 Commit 6d0349d has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#95316 (Rustdoc: Discriminate required and provided associated constants and types) - rust-lang#95405 (Move name resolution logic to a dedicated file) - rust-lang#95914 (Implement tuples using recursion) - rust-lang#95918 (Delay a bug when we see SelfCtor in ref pattern) - rust-lang#95970 (Fix suggestions in case of `T:` bounds) - rust-lang#95973 (prevent opaque types from appearing in impl headers) - rust-lang#95986 (Autolabel library PRs with T-libs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @lqd
opaque types are not distinguishable from their hidden type at the codegen stage. So we could either end up with cases where the hidden type doesn't implement the trait (which will thus ICE) or where the hidden type does implement the trait (so we'd be using its impl instead of the one written for the opaque type). This can even lead to unsound behaviour without unsafe code.
Fixes#86411.
Fixes#84660.
rebase of #87382 plus some diagnostic tweaks