Skip to content

clarify doc(cfg) wording - #96059

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:doc-cfg
Apr 16, 2022
Merged

clarify doc(cfg) wording#96059
bors merged 1 commit into
rust-lang:masterfrom
euclio:doc-cfg

Conversation

@euclio

Copy link
Copy Markdown
Contributor

The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2022
The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.
@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 15, 2022
@GuillaumeGomez

Copy link
Copy Markdown
Member

Sounds good to me, thanks! What do you think about this @Manishearth?

@ManishearthManishearth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

@Manishearth

Copy link
Copy Markdown
Member

@bors r=manishearth,guillaumegomez

@bors

bors commented Apr 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 753d567 has been approved by manishearth,guillaumegomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 15, 2022
…aumegomez
clarify doc(cfg) wording
The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.
@Dylan-DPCDylan-DPC mentioned this pull request Apr 15, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 16, 2022
…aumegomez
clarify doc(cfg) wording
The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.
@Dylan-DPCDylan-DPC mentioned this pull request Apr 16, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Apr 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2022
Rollup of 7 pull requests
Successful merges:
- rust-lang#95887 (resolve: Create dummy bindings for all unresolved imports)
- rust-lang#96023 (couple of clippy::perf fixes)
- rust-lang#96035 (Update GitHub Actions actions/checkout Version v2 -> v3)
- rust-lang#96038 (docs: add link from zip to unzip)
- rust-lang#96047 (:arrow_up: rust-analyzer)
- rust-lang#96059 (clarify doc(cfg) wording)
- rust-lang#96081 (Make some `usize`-typed masks definitions agnostic to the size of `usize`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1bce78a into rust-lang:masterApr 16, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 16, 2022
@euclio
euclio deleted the doc-cfg branch April 16, 2022 17:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@euclio@rust-highfive@GuillaumeGomez@Manishearth@bors@rustbot