Skip to content

to_digit tweak - #96124

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:to_digit_speedup4
Apr 17, 2022
Merged

to_digit tweak#96124
bors merged 1 commit into
rust-lang:masterfrom
gilescope:to_digit_speedup4

Conversation

@gilescope

@gilescopegilescope commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

No need to check the assert all the time.

(Checked the TODO and it's not time to get rid of it yet)

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 16, 2022
@rust-highfive

rust-highfive commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2022
@gilescope

gilescope commented Apr 16, 2022

Copy link
Copy Markdown
ContributorAuthor

(I did this a while ago but then managed to undo it when I did some other optimisations to the function)

@thomcc

thomcc commented Apr 16, 2022

Copy link
Copy Markdown
Member

I'd be surprised if it matters much but seems fine to me.

@bors r+

@bors

bors commented Apr 16, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit bf02d1e has been approved by thomcc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 16, 2022
@Dylan-DPC
Rollup merge ofrust-lang#96124- gilescope:to_digit_speedup4, r=thomcc
b45a233
to_digit tweak
No need to check the assert all the time.
(Checked the TODO and it's not time to get rid of it yet)
@Dylan-DPCDylan-DPC mentioned this pull request Apr 16, 2022
Closed
@Dylan-DPCDylan-DPC mentioned this pull request Apr 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2022
@bors
Auto merge ofrust-lang#96134- Dylan-DPC:rollup-ejug3yq, r=Dylan-DPC
2c28b0e
Rollup of 6 pull requests
Successful merges:
- rust-lang#95346 (Stablize `const_extern_fn` for "Rust" and "C")
- rust-lang#95933 (htmldocck: Compare HTML tree instead of plain text html)
- rust-lang#96105 (Make the debug output for `TargetSelection` less verbose)
- rust-lang#96112 (Strict provenance lint diagnostics improvements)
- rust-lang#96119 (update Miri)
- rust-lang#96124 (to_digit tweak)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b47265e into rust-lang:masterApr 17, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gilescope@rust-highfive@thomcc@bors@rustbot