Prevent `<>` links to be interpreted for intra-doc links by GuillaumeGomez · Pull Request #96187 · rust-lang/rust

GuillaumeGomez · 2022-04-18T18:56:06Z

As discussed in this thread. As mentioned, the intra-doc RFC states that <> links shouldn't be potential intra-doc links: https://rust-lang.github.io/rfcs/1946-intra-rustdoc-links.html#no-autolinks-style.

I renamed markdown_links into potential_intra_doc_markdown_links to make it more obvious what it's doing.

cc @petrochenkov
r? @notriddle

GuillaumeGomez · 2022-04-18T18:57:24Z

I don't think it should have a noticeable impact on perf but better check it:

@bors try @rust-timer queue

rust-timer · 2022-04-18T18:57:25Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-18T18:57:32Z

⌛ Trying commit 69bff8d9a6f729ec81d3e4284f17127d26e5655d with merge 60e35f84a244c676ef8161f5fc53872259f8dbb3...

bors · 2022-04-18T20:51:40Z

☀️ Try build successful - checks-actions
Build commit: 60e35f84a244c676ef8161f5fc53872259f8dbb3 (60e35f84a244c676ef8161f5fc53872259f8dbb3)

rust-timer · 2022-04-18T20:51:42Z

Queued 60e35f84a244c676ef8161f5fc53872259f8dbb3 with parent 0516711, future comparison URL.

rust-timer · 2022-04-18T21:52:55Z

Finished benchmarking commit (60e35f84a244c676ef8161f5fc53872259f8dbb3): comparison url.

Summary:

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	3	0	0	0
mean²	N/A	1.3%	N/A	N/A	N/A
max	N/A	1.4%	N/A	N/A	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

number of relevant changes↩
the arithmetic mean of the percent change↩

GuillaumeGomez · 2022-04-18T21:55:02Z

I didn't expect a regression that big...

GuillaumeGomez · 2022-04-18T22:11:51Z

Let's try with the condition in the if let binding directly if it changes anything...

@bors try @rust-timer queue

rust-timer · 2022-04-18T22:11:52Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-18T22:11:58Z

⌛ Trying commit 1040c582189442b34dd910e3cf560844ae53c76f with merge fd6020410eb7165c95aa6aa41447d02ee8d48051...

petrochenkov · 2022-04-18T22:27:59Z

I didn't expect a regression that big...

The regressions are not in rustdoc, looks like random fluctuations.

bors · 2022-04-18T23:50:54Z

☀️ Try build successful - checks-actions
Build commit: fd6020410eb7165c95aa6aa41447d02ee8d48051 (fd6020410eb7165c95aa6aa41447d02ee8d48051)

rust-timer · 2022-04-18T23:50:55Z

Queued fd6020410eb7165c95aa6aa41447d02ee8d48051 with parent 8305398, future comparison URL.

rust-timer · 2022-04-19T02:38:58Z

Finished benchmarking commit (fd6020410eb7165c95aa6aa41447d02ee8d48051): comparison url.

Summary:

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	2	0	0	0
mean²	N/A	1.2%	N/A	N/A	N/A
max	N/A	1.2%	N/A	N/A	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

number of relevant changes↩
the arithmetic mean of the percent change↩

GuillaumeGomez · 2022-04-19T09:06:45Z

No change. Well, let's go then...

@bors r=notriddle

bors · 2022-04-19T09:06:47Z

📌 Commit 1040c582189442b34dd910e3cf560844ae53c76f has been approved by notriddle

petrochenkov · 2022-04-20T16:16:18Z

Suggested change
cratefnpotential_intra_doc_markdown_links(md:&str) -> Vec<MarkdownLink>{
cratefnintra_doc_markdown_links(md:&str) -> Vec<MarkdownLink>{
With #96135 preprocessing is done as a part of this function and all the returned links are indeed intra doc links.

I'll keep the kind pattern matching but I'll remove the other changes.

bors · 2022-04-20T16:50:19Z

☔ The latest upstream changes (presumably #96135) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2022-04-20T19:08:54Z

@bors r=notriddle

bors · 2022-04-20T19:08:55Z

📌 Commit f988f86 has been approved by notriddle

bors · 2022-04-20T21:32:04Z

⌛ Testing commit f988f86 with merge 879aff3...

bors · 2022-04-20T23:51:35Z

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 879aff3 to master...

rust-timer · 2022-04-21T00:56:50Z

Finished benchmarking commit (879aff3): comparison url.

Summary:

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	0	0	0	1
mean²	1.7%	N/A	N/A	N/A	1.7%
max	1.7%	N/A	N/A	N/A	1.7%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes↩
the arithmetic mean of the percent change↩

GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 18, 2022

rust-highfive assigned notriddle Apr 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2022

notriddle approved these changes Apr 18, 2022
View reviewed changes

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2022

GuillaumeGomez force-pushed the potential-intra-doc-links-filtering branch 2 times, most recently from 4222a13 to 1040c58Compare April 18, 2022 22:11

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 19, 2022

GuillaumeGomez removed the perf-regression Performance regression. label Apr 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2022

petrochenkov reviewed Apr 20, 2022
View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2022

GuillaumeGomez force-pushed the potential-intra-doc-links-filtering branch from 1040c58 to 33aee10Compare April 20, 2022 18:12

This comment has been minimized.
Sign in to view

Remove <> links to be potential intra-doc links
f988f86

GuillaumeGomez force-pushed the potential-intra-doc-links-filtering branch from 33aee10 to f988f86Compare April 20, 2022 18:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 20, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 20, 2022

bors merged commit 879aff3 into rust-lang:masterApr 20, 2022

rustbot added this to the 1.62.0 milestone Apr 20, 2022

GuillaumeGomez deleted the potential-intra-doc-links-filtering branch April 21, 2022 08:46

petrochenkov mentioned this pull request May 15, 2022
rustdoc: Remove doc link resolution fallback to all macro_rules in the crate #96676
Merged

	cratefnpotential_intra_doc_markdown_links(md:&str) -> Vec<MarkdownLink>{
	cratefnintra_doc_markdown_links(md:&str) -> Vec<MarkdownLink>{

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Apr 18, 2022

Uh oh!

GuillaumeGomez commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 18, 2022

Uh oh!

bors commented Apr 18, 2022

Uh oh!

bors commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 18, 2022

Footnotes

Uh oh!

GuillaumeGomez commented Apr 18, 2022

Uh oh!

GuillaumeGomez commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 18, 2022

Uh oh!

bors commented Apr 18, 2022

Uh oh!

petrochenkov commented Apr 18, 2022

Uh oh!

bors commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 18, 2022

Uh oh!

rust-timer commented Apr 19, 2022

Footnotes

Uh oh!

GuillaumeGomez commented Apr 19, 2022

Uh oh!

bors commented Apr 19, 2022

Uh oh!

petrochenkovApr 20, 2022

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezApr 20, 2022

Choose a reason for hiding this comment

Uh oh!

bors commented Apr 20, 2022

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Apr 20, 2022

Uh oh!

bors commented Apr 20, 2022

Uh oh!

bors commented Apr 20, 2022

Uh oh!

bors commented Apr 20, 2022

Uh oh!

rust-timer commented Apr 21, 2022

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants