Skip to content

rustdoc: Optimize IdMap - #96260

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:rustdoc-idmap
Apr 21, 2022
Merged

rustdoc: Optimize IdMap#96260
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:rustdoc-idmap

Conversation

@Kobzol

Copy link
Copy Markdown
Member

Slightly optimizes IdMap, which is hot in markdown_links (context here). There are more improvements that can be made near this place, but this seemed like an easy win locally (although I tried it on top of #94857, so let's see what happens without that PR).

r? @petrochenkov

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 20, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 20, 2022
@bors

bors commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 34e2d3b with merge 9342e57819dbf87e987f6c94aef9dd170cd69646...

@bors

bors commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 9342e57819dbf87e987f6c94aef9dd170cd69646 (9342e57819dbf87e987f6c94aef9dd170cd69646)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued 9342e57819dbf87e987f6c94aef9dd170cd69646 with parent 51ea9bb, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9342e57819dbf87e987f6c94aef9dd170cd69646): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count100111511
mean2N/AN/A-0.7%-0.6%-0.7%
maxN/AN/A-3.1%-2.3%-3.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2022
@Kobzol

Copy link
Copy Markdown
MemberAuthor

For comparison, when this was applied after the PR which stops resolver cloning, it improved helloworld doc by almost 5 %.

@petrochenkov

Copy link
Copy Markdown
Contributor

Nice.
@bors r+

@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 34e2d3b has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 34e2d3b with merge 5915368c701f5cf205894c7d1b0e7aa0a480d60a...

@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2022
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 34e2d3b with merge de1bc00...

@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing de1bc00 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2022
@bors
bors merged commit de1bc00 into rust-lang:masterApr 21, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 21, 2022
@Kobzol
Kobzol deleted the rustdoc-idmap branch April 21, 2022 21:21
@borsbors mentioned this pull request Apr 21, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (de1bc00): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count110111512
mean21.0%N/A-0.7%-0.6%-0.6%
max1.0%N/A-3.1%-2.3%-3.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Kobzol@rust-timer@bors@petrochenkov@rust-log-analyzer@rust-highfive@rustbot