Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Optimize IdMap - #96260
Conversation
Kobzol
commented
Apr 20, 2022
@bors try @rust-timer queue |
rust-timer
commented
Apr 20, 2022
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bors
commented
Apr 20, 2022
⌛ Trying commit 34e2d3b with merge 9342e57819dbf87e987f6c94aef9dd170cd69646... |
bors
commented
Apr 20, 2022
☀️ Try build successful - checks-actions |
rust-timer
commented
Apr 20, 2022
Queued 9342e57819dbf87e987f6c94aef9dd170cd69646 with parent 51ea9bb, future comparison URL. |
rust-timer
commented
Apr 21, 2022
Finished benchmarking commit (9342e57819dbf87e987f6c94aef9dd170cd69646): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
Kobzol
commented
Apr 21, 2022
For comparison, when this was applied after the PR which stops resolver cloning, it improved helloworld doc by almost 5 %. |
petrochenkov
commented
Apr 21, 2022
Nice. |
bors
commented
Apr 21, 2022
📌 Commit 34e2d3b has been approved by |
bors
commented
Apr 21, 2022
⌛ Testing commit 34e2d3b with merge 5915368c701f5cf205894c7d1b0e7aa0a480d60a... |
bors
commented
Apr 21, 2022
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Apr 21, 2022
Kobzol
commented
Apr 21, 2022
@bors retry |
bors
commented
Apr 21, 2022
bors
commented
Apr 21, 2022
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 21, 2022
Finished benchmarking commit (de1bc00): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Slightly optimizes
IdMap, which is hot inmarkdown_links(context here). There are more improvements that can be made near this place, but this seemed like an easy win locally (although I tried it on top of #94857, so let's see what happens without that PR).r? @petrochenkov