Skip to content

errors: minor translation-related changes - #96269

Merged
bors merged 2 commits into
rust-lang:masterfrom
davidtwco:diagnostic-translation-minor-changes
Apr 22, 2022
Merged

errors: minor translation-related changes#96269
bors merged 2 commits into
rust-lang:masterfrom
davidtwco:diagnostic-translation-minor-changes

Conversation

@davidtwco

Copy link
Copy Markdown
Member
  • For one error in typeck, specifying "suggestion" as the attribute for the only suggestion is unnecessary, it's the default of the derive.
  • The documentation comment for the SessionDiagnostic derive is out-of-date, it should have been updated in diagnostics: translation infrastructure #95512.

r? @oli-obk

Specifying "suggestion" as the attribute for the only suggestion is
unnecessary, it's the default of the derive.
Signed-off-by: David Wood <david.wood@huawei.com>
The documentation comment for this derive is out-of-date, it should have
been updated in rust-lang#95512.
Signed-off-by: David Wood <david.wood@huawei.com>
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 21, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2022
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit f79d5e9 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Apr 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#95434 (Only output DepKind in dump-dep-graph.)
- rust-lang#96248 (Stop using a string literal as a format argument)
- rust-lang#96251 (Update books)
- rust-lang#96269 (errors: minor translation-related changes)
- rust-lang#96289 (Remove redundant `format!`s)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 35ef5c6 into rust-lang:masterApr 22, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 22, 2022
@davidtwco
davidtwco deleted the diagnostic-translation-minor-changes branch April 22, 2022 01:59
@compiler-errorscompiler-errors added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@davidtwco@oli-obk@bors@compiler-errors@rust-highfive@rustbot