Skip to content

Make E0117 error clear - #96273

Merged
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:make-E0117-error-clear
Apr 22, 2022
Merged

Make E0117 error clear#96273
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:make-E0117-error-clear

Conversation

@TaKO8Ki

Copy link
Copy Markdown
Member

closes#96227

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 21, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2022

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a comment.

Comment threadcompiler/rustc_typeck/src/coherence/orphan.rs Outdated
@TaKO8Ki
TaKO8Ki requested a review from davidtwcoApril 22, 2022 06:26
@davidtwco

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 22, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit f5a8ee4 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2022
…askrgr
Rollup of 3 pull requests
Successful merges:
- rust-lang#96272 (Update `validate_uninhabited_zsts.rs` test after MIR building changes)
- rust-lang#96273 (Make `E0117` error clear)
- rust-lang#96315 (Make the lifetime accurate which is used in the region constraints part)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b100c02 into rust-lang:masterApr 22, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 22, 2022
@TaKO8Ki
TaKO8Ki deleted the make-E0117-error-clear branch April 23, 2022 02:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "only traits defined in the current crate can be implemented for arbitrary types" less vague

5 participants

@TaKO8Ki@rust-highfive@davidtwco@bors@rustbot