The default_stat fn should be public by MicahChalmer · Pull Request #9637 · rust-lang/rust

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

MicahChalmer · 2013-09-30T23:40:52Z

Anybody working with a C API that uses the stat structure will want default_stat to be accessible, since, as can be seen by the implementation of default_stat, all uses of stat without it would need to be platform-specific.

In this PR I have simply made it public--I would understand if there was a desire to put the public API somewhere else instead. (There is no reason it should be in std::path.) Maybe an impl of Default in std::libc itself?

alexcrichton · 2013-10-01T00:33:11Z

This seems like a good candidate for using a re-export instead of having to reach all the way into std::path::stat::arch::default_stat.

huonw · 2013-10-01T00:48:25Z

I also imagine that @kballard's upcoming path rewrite will obsolete this(?).

lilyball · 2013-10-01T01:20:44Z

No, I copied the stat modules as-is into the new Path. I figure they can be rewritten later.

However, I don't think that we should make default_stat() public. Instead, stat should implement the Default trait (could even be derived, since all the fields should be 0). I already filed this as #9537.

MicahChalmer · 2013-10-01T05:00:42Z

I submitted a new pull request (#9652) with a version that actually implements Default for stat. For most of the os/architectures I couldn't use Deriving because of the arrays, unfortunately. If that one gets merged, this one can be closed, or vice versa.

alexcrichton · 2013-10-19T18:04:58Z

Closing for reasons outlined in #9652

Add `unused_format_specs` lint Currently catches two cases: An empty precision specifier: ```rust // the same as {} println!("{:.}", x); ``` And using formatting specs on `format_args!()`: ```rust // prints `x.`, not `x .` println("{:5}.", format_args!("x")); ``` changelog: new lint: [`unused_format_specs`]

9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Make default_stat public
1953023

MicahChalmer mentioned this pull request Oct 1, 2013
Replace default_stat in std::path with a Default impl for libc::stat #9652
Closed

alexcrichton closed this Oct 19, 2013

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Mergerust-lang#9637
4705df4
9637: Overhaul doc_links testing infra r=Veykril a=Veykril and fix several issues with current implementation. Fixesrust-lang#9617 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

Uh oh!

Uh oh!

Conversation

MicahChalmer commented Sep 30, 2013

Uh oh!

alexcrichton commented Oct 1, 2013

Uh oh!

huonw commented Oct 1, 2013

Uh oh!

lilyball commented Oct 1, 2013

Uh oh!

MicahChalmer commented Oct 1, 2013

Uh oh!

alexcrichton commented Oct 19, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

MicahChalmer commented Sep 30, 2013

Uh oh!

alexcrichton commented Oct 1, 2013

Uh oh!

huonw commented Oct 1, 2013

Uh oh!

lilyball commented Oct 1, 2013

Uh oh!

MicahChalmer commented Oct 1, 2013

Uh oh!

alexcrichton commented Oct 19, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

MicahChalmer commented Sep 30, 2013

Uh oh!

alexcrichton commented Oct 1, 2013

Uh oh!

huonw commented Oct 1, 2013

Uh oh!

lilyball commented Oct 1, 2013

Uh oh!

MicahChalmer commented Oct 1, 2013

Uh oh!

alexcrichton commented Oct 19, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

MicahChalmer commented Sep 30, 2013

Uh oh!

alexcrichton commented Oct 1, 2013

Uh oh!

huonw commented Oct 1, 2013

Uh oh!

lilyball commented Oct 1, 2013

Uh oh!