Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #96389
Closed
GuillaumeGomez wants to merge 12 commits into
Closed
Conversation
Point at all the unnecessary trailing `#`. Better handle interaction with outer attributes when `;` is missing. Fixrust-lang#95030.
In rust-lang#96303, I changed the tests not to manage submodules, with the main goal of avoiding a clone for llvm-project. Unfortunately, there are some tests which depend on submodules - I didn't notice locally because they were already checked out for me, and CI doesn't use submodule handling at all. Fresh clones, however, were impacted: ``` failures: ---- builder::tests::defaults::doc_default stdout ---- thread 'main' panicked at 'fs::read_dir(builder.src.join(&relative_path).join("redirects")) failed with No such file or directory (os error 2)', src/bootstrap/doc.rs:232:21 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ---- builder::tests::dist::dist_only_cross_host stdout ---- thread 'main' panicked at 'fs::read_to_string(&toml_file_name) failed with No such file or directory (os error 2)', src/bootstrap/lib.rs:1314:20 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Try and get the best of both worlds by only checking out the submodules actually used in tests.
…rors Better handle too many `#` recovery in raw str Point at all the unnecessary trailing `#`. Better handle interaction with outer attributes when `;` is missing. Fixrust-lang#95030.
Switch JS code to ES6 Considering it's already quite big, I'll do the remaining files in another PR. Part of rust-lang#93058. r? ````@notriddle````
…-Simulacrum Fix running bootstrap tests on a fresh clone In rust-lang#96303, I changed the tests not to manage submodules, with the main goal of avoiding a clone for llvm-project. Unfortunately, there are some tests which depend on submodules - I didn't notice locally because they were already checked out for me, and CI doesn't use submodule handling at all. Fresh clones, however, were impacted: ``` failures: ---- builder::tests::defaults::doc_default stdout ---- thread 'main' panicked at 'fs::read_dir(builder.src.join(&relative_path).join("redirects")) failed with No such file or directory (os error 2)', src/bootstrap/doc.rs:232:21 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ---- builder::tests::dist::dist_only_cross_host stdout ---- thread 'main' panicked at 'fs::read_to_string(&toml_file_name) failed with No such file or directory (os error 2)', src/bootstrap/lib.rs:1314:20 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Try and get the best of both worlds by only checking out the submodules actually used in tests.
…-errors delay bug when adjusting `NeverToAny` twice during diagnostic code Addresses Issue 96335 (rust-lang#96335) by using `delay_span_bug` instead of an assert and returning an error type from `check_expr_meets_expectation_or_error`. Fixesrust-lang#96335
…er-errors do not consider two extern types to be similar
GuillaumeGomez
commented
Apr 25, 2022
MemberAuthor
@bors: r+ p=5 rollup=never |
bors
commented
Apr 25, 2022
Collaborator
📌 Commit 56eadf3 has been approved by |
bors
commented
Apr 25, 2022
Collaborator
⌛ Testing commit 56eadf3 with merge a7b69d109f94dc55f4ff0d49566272ebc6114b54... |
bors
commented
Apr 25, 2022
Collaborator
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Apr 25, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
GuillaumeGomez
commented
Apr 25, 2022
MemberAuthor
@bors: retry |
bors
commented
Apr 25, 2022
Collaborator
⌛ Testing commit 56eadf3 with merge b630a13bc699fd0d4342f19b89ad55534dd5f441... |
rust-log-analyzer
commented
Apr 25, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Apr 25, 2022
Collaborator
💔 Test failed - checks-actions |
GuillaumeGomez
commented
Apr 25, 2022
MemberAuthor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#recovery in raw str #96355 (Better handle too many#recovery in raw str)NeverToAnytwice during diagnostic code #96379 (delay bug when adjustingNeverToAnytwice during diagnostic code)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup