Uh oh!
There was an error while loading. Please reload this page.
Migrate ambiguous plus diagnostic to the new derive macro - #96405
Merged
Conversation
Comment on lines
+1174
to
+1181
| #[derive(SessionDiagnostic)] | ||
| #[error(slug = "parser-maybe-report-ambiguous-plus")] | ||
| struct AmbiguousPlus { | ||
| pub sum_with_parens: String, | ||
| #[primary_span] | ||
| #[suggestion(code = "{sum_with_parens}")] | ||
| pub span: Span, | ||
| } |
Contributor
There was a problem hiding this comment.
Don't want to push more work on you, but this might be a good time to check if multipart_suggestion support works as expected.
ContributorAuthor
There was a problem hiding this comment.
I'd be happy to do it but I couldn't find any examples on how to use it.
davidtwco
requested changes
Apr 26, 2022
davidtwco
left a comment
Member
There was a problem hiding this comment.
Looks great, left some minor comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
left a comment
Member
There was a problem hiding this comment.
Okay, one final small change, then r=me
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
approved these changes
Apr 27, 2022
oli-obk
commented
Apr 27, 2022
Contributor
@bors r=davidtwco |
bors
commented
Apr 27, 2022
Collaborator
📌 Commit e7ae9eb has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 27, 2022
…davidtwco Migrate ambiguous plus diagnostic to the new derive macro r? `@davidtwco` `@jyn514`
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 28, 2022
…davidtwco Migrate ambiguous plus diagnostic to the new derive macro r? ``@davidtwco`` ``@jyn514``
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 28, 2022
…davidtwco Migrate ambiguous plus diagnostic to the new derive macro r? ```@davidtwco``` ```@jyn514```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#95312 (Ensure that `'_` and GAT yields errors) - rust-lang#96405 (Migrate ambiguous plus diagnostic to the new derive macro) - rust-lang#96409 (Recover suggestions to introduce named lifetime under NLL) - rust-lang#96433 (rustc_ast: Harmonize delimiter naming with `proc_macro::Delimiter`) - rust-lang#96480 (Fixed grammatical error in example comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @davidtwco@jyn514