Skip to content

Rollup of 6 pull requests - #96459

Merged
bors merged 16 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-de6ud9d
Apr 27, 2022
Merged

Rollup of 6 pull requests#96459
bors merged 16 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-de6ud9d

Conversation

@Dylan-DPC

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

compiler-errorsand others added 16 commits April 24, 2022 15:05
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts
Improves error messaging for empty-tuple structs and enum variants in certain generic contexts. See new ui tests for examples.
Closesrust-lang#87181
…od_error, r=estebank
Cleanup `report_method_error` a bit
1. Remove an unnecessary indentation level
2. Split out a couple of large functions from this humongo function body
…bank
Fix erased region escaping into wfcheck due to rust-lang#95395
We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with...
Fixesrust-lang#96381
Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
…bound-suggestions, r=jackh726
Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL
This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from `NiceRegionError::try_report_static_impl_trait` and by re-using `suggest_new_region_bound`.
Fixesrust-lang#96277
r? ```@jackh726```
…GuillaumeGomez
rustdoc: do not write `{{root}}` in `pub use ::foo` docs
Fixesrust-lang#95873
…r=notriddle
Fix handling of `!` in rustdoc search
Fixesrust-lang#96399.
I also updated the eBNF.
cc `@jsha`
r? `@notriddle`
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 27, 2022
@Dylan-DPC

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5 rollup=never

@bors

bors commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit c0ed53c has been approved by Dylan-DPC

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2022
@bors

bors commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0ed53c with merge 99b70ee...

@bors

bors commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 99b70ee to master...

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (99b70ee): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count120002
mean20.7%N/AN/AN/A0.7%
max0.9%N/AN/AN/A0.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Dylan-DPC@bors@rust-timer@rustbot@compiler-errors@marmeladema@notriddle@GuillaumeGomez@George-lewis