Skip to content

Implement #[rustc_default_body_unstable] - #96478

Merged
bors merged 8 commits into
rust-lang:masterfrom
WaffleLapkin:rustc_default_body_unstable
Aug 9, 2022
Merged

Implement #[rustc_default_body_unstable]#96478
bors merged 8 commits into
rust-lang:masterfrom
WaffleLapkin:rustc_default_body_unstable

Conversation

@WaffleLapkin

@WaffleLapkinWaffleLapkin commented Apr 27, 2022

Copy link
Copy Markdown
Member

This PR implements a new stability attribute — #[rustc_default_body_unstable].

#[rustc_default_body_unstable] controls the stability of default bodies in traits.
For example:

pubtraitTrait{#[rustc_default_body_unstable(feature = "feat", isssue = "none")]fnitem(){}}

In order to implement Trait user needs to either

  • implement item (even though it has a default implementation)
  • enable #![feature(feat)]

This is useful in conjunction with #[rustc_must_implement_one_of], we may want to relax requirements for a trait, for example allowing implementing either of PartialEq::{eq, ne}, but do so in a safe way — making implementation of only PartialEq::ne unstable.

r? @Aaron1011
cc @nrc (iirc you were interested in this wrt read_buf), @danielhenrymantilla (you were interested in the related #[rustc_must_implement_one_of])
P.S. This is my first time working with stability attributes, so I'm not sure if I did everything right 😅

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 27, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2022
WaffleLapkin
WaffleLapkin commented Apr 27, 2022
View reviewed changes
Comment threadsrc/test/ui/stability-attribute/default-body-stability-err.stderr Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin
WaffleLapkinforce-pushed the rustc_default_body_unstable branch 3 times, most recently from 4d1cee1 to 35a5566CompareApril 27, 2022 17:35
danielhenrymantilla
danielhenrymantilla reviewed May 20, 2022
View reviewed changes
Comment threadcompiler/rustc_middle/src/middle/stability.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/mod.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/mod.rs Outdated
@bors

bors commented May 22, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #97177) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon

JohnCSimon commented Jun 20, 2022

Copy link
Copy Markdown

Ping from triage:
@WaffleLapkin can you please fix the merge conflicts?

@WaffleLapkin
WaffleLapkinforce-pushed the rustc_default_body_unstable branch 2 times, most recently from 67118a6 to 6d86e5dCompareJune 20, 2022 12:39
@bors

bors commented Jul 14, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #95956) made this pull request unmergeable. Please resolve the merge conflicts.

@WaffleLapkin
WaffleLapkinforce-pushed the rustc_default_body_unstable branch from 6d86e5d to 78eb420CompareJuly 26, 2022 10:54
@WaffleLapkin
Implement #[rustc_default_body_unstable]
177af47
This attribute allows to mark default body of a trait function as
unstable. This means that implementing the trait without implementing
the function will require enabling unstable feature.
This is useful in conjunction with `#[rustc_must_implement_one_of]`,
we may want to relax requirements for a trait, for example allowing
implementing either of `PartialEq::{eq, ne}`, but do so in a safe way
-- making implementation of only `PartialEq::ne` unstable.
@WaffleLapkin
Collect features from #[rustc_default_body_unstable]
9015a51
@WaffleLapkin
Add tests for #[rustc_default_body_unstable]
d65fa27
@WaffleLapkin
remove commented out code
1984437
@WaffleLapkin
Improve error message for unstable default body
1e1d6fe
@WaffleLapkin
WaffleLapkinforce-pushed the rustc_default_body_unstable branch from 78eb420 to 1e1d6feCompareJuly 26, 2022 11:43
@Aaron1011

Aaron1011 commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Sorry for the extreme delay - I had forgotten that this was assigned to me.

This looks good to me overall - do we need lang-team signoff before adding this?

Aaron1011
Aaron1011 reviewed Jul 29, 2022
View reviewed changes
Comment threadcompiler/rustc_attr/src/builtin.rs Outdated
Aaron1011
Aaron1011 reviewed Jul 29, 2022
View reviewed changes
Comment threadcompiler/rustc_passes/src/stability.rs Outdated
@WaffleLapkin

WaffleLapkin commented Jul 31, 2022

Copy link
Copy Markdown
MemberAuthor

do we need lang-team signoff before adding this?

I don't know, maybe 😄

@Aaron1011

Aaron1011 commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

r=me after confirmation from the libs teem that this is okay (or after an FCP if needed)

Aaron1011
Aaron1011 reviewed Aug 5, 2022
View reviewed changes
Comment threadcompiler/rustc_middle/src/middle/stability.rs Outdated
@WaffleLapkin

WaffleLapkin commented Aug 8, 2022

Copy link
Copy Markdown
MemberAuthor

@Aaron1011 why libs team approval is needed? This PR doesn't change any library APIs after all.

Quoting @scottmcm on zulip:

Looks like it doesn't change anything in library at all? If this is just a compiler feature that could be used in library later, then I don't think it's blocked on libs review.

@Aaron1011

Aaron1011 commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 95bf0fb has been approved by Aaron1011

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Aug 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2022
@bors
Auto merge ofrust-lang#100318- Dylan-DPC:rollup-18tzp6q, r=Dylan-DPC
6d3f1be
Rollup of 7 pull requests
Successful merges:
- rust-lang#96478 (Implement `#[rustc_default_body_unstable]`)
- rust-lang#99787 (Rustdoc-Json: Document HRTB's on DynTrait)
- rust-lang#100181 (add method to get the mutability of an AllocId)
- rust-lang#100221 (Don't document impossible to call default trait items on impls)
- rust-lang#100228 (Don't ICE while suggesting updating item path.)
- rust-lang#100301 (Avoid `&str` to `String` conversions)
- rust-lang#100305 (Suggest adding an appropriate missing pattern excluding comments)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1dc4858 into rust-lang:masterAug 9, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 9, 2022
@WaffleLapkin
WaffleLapkin deleted the rustc_default_body_unstable branch January 13, 2023 14:32
@WaffleLapkinWaffleLapkin mentioned this pull request Jan 30, 2023
Open
5 tasks
@diannedianne mentioned this pull request Sep 17, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Aaron1011Aaron1011Aaron1011 left review comments
@danielhenrymantilladanielhenrymantilladanielhenrymantilla approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Aaron1011Aaron1011

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@WaffleLapkin@rust-log-analyzer@bors@JohnCSimon@Aaron1011@danielhenrymantilla@rust-highfive@rustbot