Uh oh!
There was an error while loading. Please reload this page.
Add rotation animation on settings button when loading - #96704
Merged
Conversation
rust-highfive
commented
May 4, 2022
Contributor
Some changes occurred in HTML/CSS/JS. |
bors
commented
May 5, 2022
Collaborator
☔ The latest upstream changes (presumably #96720) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomezforce-pushed
the
rotation-animation
branch
from
May 5, 2022 09:08
ec47932 to
13b45aaCompareGuillaumeGomez
commented
May 5, 2022
MemberAuthor
Fixed merge conflict. |
jsha
commented
May 5, 2022
Contributor
Can you put up a demo? |
GuillaumeGomez
commented
May 5, 2022
MemberAuthor
Unless you block the JS to be downloaded, you won't be able to see the rotation. Do you want me to put up a demo in any case? |
jsha
commented
May 5, 2022
Contributor
Yep - devtools can do various things to simulate slow or offline loading. There's also a very simple expedient to test such things - turn of your Wi-Fi. :-) |
GuillaumeGomez
commented
May 5, 2022
MemberAuthor
Such ancient dark magic. A world where you can turn off the internet. This is too scary to even imagine it. 😨 (uploading the demo 😆 ) |
GuillaumeGomez
commented
May 5, 2022
MemberAuthor
The demo is now up here. |
jsha
commented
May 5, 2022
Contributor
@bors r+ rollup Nice! |
bors
commented
May 5, 2022
Collaborator
📌 Commit 13b45aa has been approved by |
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
May 5, 2022
…r=jsha Add rotation animation on settings button when loading As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like): https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4 r? ``@jsha``
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
May 6, 2022
…r=jsha Add rotation animation on settings button when loading As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like): https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4 r? ```@jsha```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2022
…piler-errors Rollup of 7 pull requests Successful merges: - rust-lang#96174 (mark ptr-int-transmute test as no_run) - rust-lang#96639 (Fix typo in `offset_from` documentation) - rust-lang#96704 (Add rotation animation on settings button when loading) - rust-lang#96730 (Add a regression test for rust-lang#64173 and rust-lang#66152) - rust-lang#96741 (Improve settings loading strategy) - rust-lang#96744 (Implement [OsStr]::join) - rust-lang#96747 (Add `track_caller` to `DefId::expect_local()`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the
settings.jssuper long so we can see what the animation looks like):Peek.2022-05-04.15-38.mp4
r? @jsha