Skip to content

Put the incompatible_closure_captures lint messages in alphabetical order - #96752

Merged
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:error-sorting
May 6, 2022
Merged

Put the incompatible_closure_captures lint messages in alphabetical order#96752
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:error-sorting

Conversation

@scottmcm

Copy link
Copy Markdown
Member

Looks like they were in hash order before, which was causing me trouble in #94598, so this PR sorts the errors by trait name.

Looks like they were in FxHash order before, so it might just be luck that this used to be consistent across different word lengths.
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2022
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 6, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 30309db has been approved by compiler-errors

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 6, 2022
…errors
Put the incompatible_closure_captures lint messages in alphabetical order
Looks like they were in hash order before, which was causing me trouble in rust-lang#94598, so this PR sorts the errors by trait name.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 6, 2022
…errors
Put the incompatible_closure_captures lint messages in alphabetical order
Looks like they were in hash order before, which was causing me trouble in rust-lang#94598, so this PR sorts the errors by trait name.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 6, 2022
…errors
Put the incompatible_closure_captures lint messages in alphabetical order
Looks like they were in hash order before, which was causing me trouble in rust-lang#94598, so this PR sorts the errors by trait name.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2022
…laumeGomez
Rollup of 10 pull requests
Successful merges:
- rust-lang#96557 (Allow inline consts to reference generic params)
- rust-lang#96590 (rustdoc: when running a function-signature search, tweak the tab bar)
- rust-lang#96650 (Collect function instance used in `global_asm!` sym operand)
- rust-lang#96733 (turn `append_place_to_string` from recursion into iteration)
- rust-lang#96748 (Fixes reexports in search)
- rust-lang#96752 (Put the incompatible_closure_captures lint messages in alphabetical order)
- rust-lang#96754 (rustdoc: ensure HTML/JS side implementors don't have dups)
- rust-lang#96772 (Suggest fully qualified path with appropriate params)
- rust-lang#96776 (Fix two minor issues in hir.rs)
- rust-lang#96782 (a small `mirror_expr` cleanup)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 28d85ab into rust-lang:masterMay 6, 2022
@rustbotrustbot added this to the 1.62.0 milestone May 6, 2022
@scottmcm
scottmcm deleted the error-sorting branch May 6, 2022 23:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@scottmcm@rust-highfive@compiler-errors@bors@estebank@rustbot