Uh oh!
There was an error while loading. Please reload this page.
A few rustdoc source view improvements - #9684
Closed
Seldaek wants to merge 3 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
Seeing how this kinda exists for aesthetic pleasure, seems like we should collapse in the case linefrom == lineto
alexcrichton
commented
Oct 2, 2013
Member
Rolling into #9691 |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 23, 2022
`ref_option_ref` do not lint when inner reference is mutable changelog: FP: [`ref_option_ref`]: No longer lints if the inner reference is mutable fixrust-lang/rust-clippy#9682
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
9684: Complete editable private items r=jonas-schievink a=jonas-schievink This checks if a private item's location is editable (local source root), and completes them anyways if that's the case. In order to test this, the `new_source_root` fixture command has been changed to take a `local` or `library` value, and to apply to all *following* files instead of the preceding ones (which would be hard to understand). bors r+ Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alexcrichton