Skip to content

rustdoc: search result ranking fix - #96879

Merged
bors merged 2 commits into
rust-lang:masterfrom
notriddle:notriddle/search-ranking
May 10, 2022
Merged

rustdoc: search result ranking fix#96879
bors merged 2 commits into
rust-lang:masterfrom
notriddle:notriddle/search-ranking

Conversation

@notriddle

@notriddlenotriddle commented May 9, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Before

image

After

image

@rust-highfive

rust-highfive commented May 9, 2022

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 9, 2022
@rust-highfive

rust-highfive commented May 9, 2022

Copy link
Copy Markdown
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2022
@GuillaumeGomez

GuillaumeGomez commented May 9, 2022

Copy link
Copy Markdown
Member

This is a great improvement! Could you add the test you used for HashSet::insert too please? (in rustdoc-js-std)

GuillaumeGomez
GuillaumeGomez reviewed May 9, 2022
View reviewed changes
Comment threadsrc/test/rustdoc-js-std/path-ordering.js Outdated
@notriddle

notriddle commented May 9, 2022

Copy link
Copy Markdown
ContributorAuthor

Okay, I've added a test case for hashset::insert in std.

@notriddle
notriddleforce-pushed the notriddle/search-ranking branch from 471b0bc to c683810CompareMay 9, 2022 19:19
@notriddle
notriddleforce-pushed the notriddle/search-ranking branch from c683810 to a9a90d4CompareMay 9, 2022 19:24
@GuillaumeGomez

GuillaumeGomez commented May 9, 2022

Copy link
Copy Markdown
Member

Thanks! r=me once CI pass.

@notriddle

notriddle commented May 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r=GuillaumeGomez

@bors

bors commented May 9, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a9a90d4 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
@oli-obk

oli-obk commented May 10, 2022

Copy link
Copy Markdown
Contributor

@bors rollup

@JohnTitorJohnTitor mentioned this pull request May 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2022
@bors
Auto merge ofrust-lang#96904- JohnTitor:rollup-f1sz5x0, r=JohnTitor
d4c3643
Rollup of 6 pull requests
Successful merges:
- rust-lang#96717 (Handle mismatched generic param kinds in trait impls betterly)
- rust-lang#96725 (Expose process windows_process_extensions_main_thread_handle on Windows)
- rust-lang#96849 (Move some tests to more reasonable places)
- rust-lang#96861 (Use Rust 2021 prelude in std itself.)
- rust-lang#96879 (rustdoc: search result ranking fix)
- rust-lang#96882 (Don't subst an AdtDef with its own substs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d34915f into rust-lang:masterMay 10, 2022
@rustbotrustbot added this to the 1.62.0 milestone May 10, 2022
@notriddle
notriddle deleted the notriddle/search-ranking branch May 11, 2022 15:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@jshajsha

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

7 participants

@notriddle@rust-highfive@GuillaumeGomez@bors@oli-obk@jsha@rustbot