Stabilize `Ipv6Addr::to_ipv4_mapped` by tbu- · Pull Request #96906 · rust-lang/rust

tbu- · 2022-05-10T16:10:52Z

CC #27709 (tracking issue for the ip feature which contains more
functions)

The function Ipv6Addr::to_ipv4 is bad because it also returns an IPv4
address for the IPv6 loopback address ::1. Stabilize
Ipv6Addr::to_ipv4_mapped so we can recommend that function instead.

CC rust-lang#27709 (tracking issue for the `ip` feature which contains more functions) The function `Ipv6Addr::to_ipv4` is bad because it also returns an IPv4 address for the IPv6 loopback address `::1`. Stabilize `Ipv6Addr::to_ipv4_mapped` so we can recommend that function instead.

Fixesrust-lang#96718.

rust-highfive · 2022-05-10T16:10:54Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-05-10T16:10:56Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

tbu- · 2022-05-10T16:12:01Z

r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs

dtolnay · 2022-05-10T21:58:19Z

@rust-lang/libs-api:
@rfcbot fcp merge

https://doc.rust-lang.org/std/net/struct.Ipv6Addr.html#method.to_ipv4_mapped

rfcbot · 2022-05-10T21:58:20Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2022-05-18T18:07:31Z

🔔 This is now entering its final comment period, as per the review above. 🔔

dtolnay · 2022-05-22T23:33:54Z

@bors r+

bors · 2022-05-22T23:33:56Z

📌 Commit 813c5b0 has been approved by dtolnay

bors · 2022-05-23T00:10:11Z

⌛ Testing commit 813c5b0 with merge d125574...

bors · 2022-05-23T02:50:44Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing d125574 to master...

rust-timer · 2022-05-23T04:10:00Z

Finished benchmarking commit (d125574): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 🎉 relevant improvements found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	0	1	2	1
mean²	N/A	N/A	-3.2%	-1.9%	-3.2%
max	N/A	N/A	-3.2%	-2.0%	-3.2%

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	0	1	0	2
mean²	2.4%	N/A	-1.6%	N/A	0.4%
max	2.4%	N/A	-1.6%	N/A	2.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes↩↩²
the arithmetic mean of the percent change↩↩²

tbu- added 2 commits May 10, 2022 18:06

Recommend Ipv6Addr::to_ipv4_mapped over Ipv6Addr::to_ipv4
813c5b0
Fixesrust-lang#96718.

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 10, 2022

rust-highfive assigned kennytm May 10, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022

rustbot added the T-libs-api [DEPRECATED; DO NOT USE] label May 10, 2022

rust-highfive assigned dtolnay and unassigned kennytm May 10, 2022

rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 10, 2022

tbu- changed the title ~~Stabilize Ipv6Addr::to_ipv4_mapped~~Stabilize Ipv6Addr::to_ipv4_mappedMay 10, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 10, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 18, 2022

dtolnay approved these changes May 22, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2022

bors merged commit d125574 into rust-lang:masterMay 23, 2022

rustbot added this to the 1.63.0 milestone May 23, 2022

klensy reviewed May 23, 2022
View reviewed changes

Comment threadlibrary/std/src/net/ip.rs

apiraino removed the to-announce Announce this issue on triage meeting label Jun 9, 2022

JohnTitor added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 21, 2022

dtolnay mentioned this pull request Sep 28, 2023
Tracking issue for Ipv{4,6}Addr convenience methods #27709
Open
29 tasks

coderabbitaiBot mentioned this pull request May 15, 2026
feat: add web_fetch built-in tool endo-ly/egopulse#85
Merged

This was referenced Jul 31, 2026
feat(server): make the REST API usable by external work-queue dispatchers agent-of-empires/agent-of-empires#3187
Merged
chore(release): bump infra to 0.5.0 and api to 0.4.1 (ADR-020 D2/D6) tradem/breakdown-rs#194
Merged

coderabbitaiBot mentioned this pull request Aug 9, 2026
chore(ResearchLedger): add LICENSE + .editorconfig KooshaPari/ResearchLedger#6
Closed

Navigation Menu

Uh oh!

Uh oh!

Stabilize `Ipv6Addr::to_ipv4_mapped` - #96906

Stabilize `Ipv6Addr::to_ipv4_mapped`#96906
bors merged 2 commits into
rust-lang:masterfrom
tbu-:pr_stabilize_to_ipv4_mapped

tbu- commented May 10, 2022

Uh oh!

rust-highfive commented May 10, 2022

Uh oh!

rust-highfive commented May 10, 2022

Uh oh!

tbu- commented May 10, 2022

Uh oh!

dtolnay commented May 10, 2022

Uh oh!

rfcbot commented May 10, 2022•
edited by BurntSushi
Loading

Uh oh!

rfcbot commented May 18, 2022

Uh oh!

dtolnay commented May 22, 2022

Uh oh!

bors commented May 22, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

rust-timer commented May 23, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

tbu- commented May 10, 2022

Uh oh!

rust-highfive commented May 10, 2022

Uh oh!

rust-highfive commented May 10, 2022

Uh oh!

tbu- commented May 10, 2022

Uh oh!

dtolnay commented May 10, 2022

Uh oh!

rfcbot commented May 10, 2022• edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented May 18, 2022

Uh oh!

dtolnay commented May 22, 2022

Uh oh!

bors commented May 22, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

rust-timer commented May 23, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rfcbot commented May 10, 2022•
edited by BurntSushi
Loading