Skip to content

Forbid nested opaque types to reference HRTB from opaque types. - #97039

Merged
bors merged 2 commits into
rust-lang:masterfrom
cjgillot:no-rpit-hrtb
May 14, 2022
Merged

Forbid nested opaque types to reference HRTB from opaque types.#97039
bors merged 2 commits into
rust-lang:masterfrom
cjgillot:no-rpit-hrtb

Conversation

@cjgillot

Copy link
Copy Markdown
Contributor

Avoids #96194
Alternative to #96970

r? @oli-obk

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 14, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2022
@aliemjay

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

@aliemjay: 🔑 Insufficient privileges: not in try users

@cjgillot

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit b276b65 with merge 964cb6ab31b62c60eb4b2fdc021a166f0b6076d4...

@jackh726

Copy link
Copy Markdown
Member

This seems much nicer than #96970.

Crater run for this can happen in parallel, but let's get this in for the release train.

@bors r+ p=1

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 872f09c has been approved by jackh726

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2022
@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 872f09c with merge b36be12...

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing b36be12 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
Forbid nested opaque types to reference HRTB from opaque types.
Backport version of rust-lang#97039 if useful.
r? `@Mark-Simulacrum`
@bors
bors merged commit b36be12 into rust-lang:masterMay 14, 2022
@rustbotrustbot added this to the 1.62.0 milestone May 14, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b36be12): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Mark-Simulacrum

Copy link
Copy Markdown
Member

Backported to beta via #97040.

@cjgillot
cjgillot deleted the no-rpit-hrtb branch May 17, 2022 14:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@cjgillot@aliemjay@bors@jackh726@rust-timer@Mark-Simulacrum@oli-obk@rust-highfive@rustbot