Skip to content

Fix rustc-perf benchmarks - #97044

Merged
bors merged 1 commit into
rust-lang:masterfrom
Urgau:check-cfg-fix-rustc-perf
May 14, 2022
Merged

Fix rustc-perf benchmarks#97044
bors merged 1 commit into
rust-lang:masterfrom
Urgau:check-cfg-fix-rustc-perf

Conversation

@Urgau

@UrgauUrgau commented May 14, 2022

Copy link
Copy Markdown
Member

@rust-highfive

rust-highfive commented May 14, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2022
@Urgau
Urgauforce-pushed the check-cfg-fix-rustc-perf branch from b9e7802 to 9a4285cCompareMay 14, 2022 14:18
@UrgauUrgau mentioned this pull request May 14, 2022
Closed
@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2022

Copy link
Copy Markdown
Member

@bors r+ p=1

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 9a4285c has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2022
@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9a4285c with merge 70b3681...

@bors

bors commented May 14, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 70b3681 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2022
@bors
bors merged commit 70b3681 into rust-lang:masterMay 14, 2022
@rustbotrustbot added this to the 1.62.0 milestone May 14, 2022
@rust-timer

rust-timer commented May 15, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (70b3681): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@UrgauUrgau mentioned this pull request May 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
@bors
Auto merge ofrust-lang#97529- Urgau:bootstrap-check-cfg-features, r…
3a8e713
…=Mark-Simulacrum
Use new cargo argument in bootstrap for cfg checking
This PR use new cargo argument in bootstrap for doing cfg checking.
Follow-up to rust-lang#97044 and rust-lang#97214.
r? `@Mark-Simulacrum`
@Urgau
Urgau deleted the check-cfg-fix-rustc-perf branch May 5, 2023 16:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Urgau@rust-highfive@Mark-Simulacrum@bors@rust-timer@rustbot