Skip to content

rustdoc: Remove ItemFragment(Kind) - #97066

Merged
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:nofragkind
May 27, 2022
Merged

rustdoc: Remove ItemFragment(Kind)#97066
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:nofragkind

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented May 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

And stop using write! when rendering URL fragments to avoid impossible errors.

@rust-highfive

rust-highfive commented May 15, 2022

Copy link
Copy Markdown
Contributor

Some changes occurred in clean/types.rs.

cc @camelid

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 15, 2022
@rust-highfive

rust-highfive commented May 15, 2022

Copy link
Copy Markdown
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2022
@petrochenkov

petrochenkov commented May 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented May 15, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2022
@bors

bors commented May 15, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c3a5401ec6b077cfd909e391a027426738bad941 with merge 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e...

@petrochenkovpetrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2022
@bors

bors commented May 16, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e (3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e)

@rust-timer

rust-timer commented May 16, 2022

Copy link
Copy Markdown
Collaborator

Queued 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e with parent 29e972d, future comparison URL.

@rust-timer

rust-timer commented May 16, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 16, 2022
@petrochenkov

petrochenkov commented May 16, 2022

Copy link
Copy Markdown
ContributorAuthor

I need to think about what should be cached here and what should not.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2022
@jsha

jsha commented May 16, 2022

Copy link
Copy Markdown
Contributor

@camelid are you available to review this one? It looks like it's related to stuff you've worked on recently.

camelid
camelid reviewed May 20, 2022
View reviewed changes

@camelidcamelid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. I think you mentioned you need to investigate the caching some more?

Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@camelidcamelid assigned camelid and unassigned jshaMay 20, 2022
@petrochenkov

petrochenkov commented May 20, 2022

Copy link
Copy Markdown
ContributorAuthor

I think you mentioned you need to investigate the caching some more?

Yes, maybe not for the UrlFragment rendering stuff, because it doesn't affect performance, but for the extra_fragment stuff because it may affect deduplication of the produced errors.

@petrochenkov

petrochenkov commented May 21, 2022

Copy link
Copy Markdown
ContributorAuthor

I've removed changes that could affect error deduplication.
@rustbot ready

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 21, 2022
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2022
@camelid

camelid commented May 26, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 26, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 3f21c31 has been approved by camelid

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2022
@camelid

camelid commented May 26, 2022

Copy link
Copy Markdown
Member

Might affect perf. @bors rollup=never

@camelid

camelid commented May 26, 2022

Copy link
Copy Markdown
Member

Oops, I forgot there was already a perf run that showed no changes. @bors rollup

@compiler-errorscompiler-errors mentioned this pull request May 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2022
@bors
Auto merge ofrust-lang#97444- compiler-errors:rollup-2gvdav6, r=com…
9a42c65
…piler-errors
Rollup of 3 pull requests
Successful merges:
- rust-lang#96051 (Use rounding in float to Duration conversion methods)
- rust-lang#97066 (rustdoc: Remove `ItemFragment(Kind)`)
- rust-lang#97436 (Update `triagebot.toml` for macos ping group)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 8eb4fc6 into rust-lang:masterMay 27, 2022
@rustbotrustbot added this to the 1.63.0 milestone May 27, 2022
@petrochenkov
petrochenkov deleted the nofragkind branch February 22, 2025 18:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelidcamelidcamelid approved these changes

Assignees

@camelidcamelid

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@petrochenkov@rust-highfive@rust-timer@bors@jsha@camelid@rustbot