Add a test for issue #33172 by rylev · Pull Request #97085 · rust-lang/rust

rylev · 2022-05-16T17:06:34Z

Adds a test confirming that #33172 has been fixed.

CDB has some surprising results as it looks like the supposedly unmangled static's symbol name is prefixed when it shouldn't be.

r? @wesleywiser

Closes#33172

wesleywiser · 2022-06-20T18:18:42Z

Thanks @rylev!

@bors r+

bors · 2022-06-20T18:18:43Z

📌 Commit 3ea686f has been approved by wesleywiser

Add a test for issue rust-lang#33172 Adds a test confirming that rust-lang#33172 has been fixed. CDB has some surprising results as it looks like the supposedly unmangled static's symbol name is prefixed when it shouldn't be. r? ``@wesleywiser`` Closesrust-lang#33172

JohnTitor · 2022-06-21T08:09:55Z

Failed in rollup: #98321 (comment)
@bors r-

wesleywiser · 2022-06-23T23:26:53Z

@bors r+

Add a test for issue rust-lang#33172 Adds a test confirming that rust-lang#33172 has been fixed. CDB has some surprising results as it looks like the supposedly unmangled static's symbol name is prefixed when it shouldn't be. r? ```@wesleywiser``` Closesrust-lang#33172

JohnTitor · 2022-06-25T09:51:00Z

Failed in rollup: #98480 (comment)
@bors r- rollup=iffy

wesleywiser · 2022-06-27T14:58:47Z

Looks like this might be an issue with older gdb version?

NOTE: compiletest thinks it is using GDB version 7011001

We might need to restrict this to a newer version via the min-gdb-version compile test directive.

Co-authored-by: Wesley Wiser <wwiser@gmail.com>

rylev · 2022-08-04T09:58:02Z

@wesleywiser I pushed a change to set the min-version to higher than the default. Unfortunately, I'm having a hard time getting an old version of gdb working with my local test setup to test locally. It would be nice if we could run the debugger suite before it goes into a rollup and potentially fails.

wesleywiser · 2022-08-04T21:00:55Z

@bors r+ rollup=never

bors · 2022-08-04T21:00:56Z

📌 Commit 6cc3b41 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2022-08-05T03:26:56Z

⌛ Testing commit 6cc3b41 with merge 6bcf01a...

bors · 2022-08-05T06:35:06Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 6bcf01a to master...

rust-timer · 2022-08-05T07:52:33Z

Finished benchmarking commit (6bcf01a): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.2%	1.2%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	2.1%	2.1%	1
Regressions 😿 (secondary)	3.0%	3.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.1%	2.1%	1

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.9%	-2.9%	1
Improvements 🎉 (secondary)	-3.8%	-3.8%	1
All 😿🎉 (primary)	-2.9%	-2.9%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

wesleywiser · 2022-08-05T14:44:04Z

I think it's safe to ignore this perf result since this PR only adds a debuginfo test and touches no other code so by definition, it couldn't have had an effect on compiler performance.

rust-highfive assigned wesleywiser May 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2022

wesleywiser reviewed May 19, 2022
View reviewed changes

Comment threadsrc/test/debuginfo/no_mangle-info.rs Outdated

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2022

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022

rylev mentioned this pull request Jun 20, 2022
Incorrect debug info for no_mangle statics on Windows #98295
Closed

rylev added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2022

rylev force-pushed the test-issue-33172 branch from 9fbf419 to 3ea686fCompare June 20, 2022 16:47

wesleywiser approved these changes Jun 20, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022

matthiaskrgr mentioned this pull request Jun 21, 2022
Rollup of 6 pull requests #98321
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2022

rylev commented Jun 21, 2022
View reviewed changes

Comment threadsrc/test/debuginfo/no_mangle-info.rs

rylev force-pushed the test-issue-33172 branch from c443851 to 1a25ac9Compare June 21, 2022 16:01

rust-lang deleted a comment from rust-log-analyzer Jun 21, 2022

rylev added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2022

wesleywiser reviewed Jun 22, 2022
View reviewed changes

Comment threadsrc/test/debuginfo/no_mangle-info.rs Outdated

rylev requested a review from wesleywiser June 23, 2022 10:02

This comment has been minimized.
Sign in to view

Dylan-DPC mentioned this pull request Jun 25, 2022
Rollup of 9 pull requests #98480
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2022

rylevand others added 7 commits August 4, 2022 10:39

Add a test for issuerust-lang#33172
e696309

Turn off cdb test for now, link to issue
f2ee124

Turn CDB test back on and all clarifying test
95f4d41

Fix linux tests
4fd0a7e

Add comment about issue caused with multiple statics
f7bfd74

Update FIXME comment
d39bc1a
Co-authored-by: Wesley Wiser <wwiser@gmail.com>

Add min-gdb-version
6cc3b41

rylev force-pushed the test-issue-33172 branch from 23d325e to 6cc3b41Compare August 4, 2022 09:54

rylev added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2022

bors merged commit 6bcf01a into rust-lang:masterAug 5, 2022

rustbot added this to the 1.64.0 milestone Aug 5, 2022

rylev deleted the test-issue-33172 branch August 5, 2022 23:34

Uh oh!

Uh oh!

Conversation

rylev commented May 16, 2022• edited by wesleywiser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

wesleywiser commented Jun 20, 2022

Uh oh!

bors commented Jun 20, 2022

Uh oh!

JohnTitor commented Jun 21, 2022

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

wesleywiser commented Jun 23, 2022

Uh oh!

JohnTitor commented Jun 25, 2022

Uh oh!

wesleywiser commented Jun 27, 2022

Uh oh!

rylev commented Aug 4, 2022

Uh oh!

wesleywiser commented Aug 4, 2022

Uh oh!

bors commented Aug 4, 2022

Uh oh!

bors commented Aug 5, 2022

Uh oh!

bors commented Aug 5, 2022

Uh oh!

rust-timer commented Aug 5, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

wesleywiser commented Aug 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

rylev commented May 16, 2022•
edited by wesleywiser
Loading