Uh oh!
There was an error while loading. Please reload this page.
Add tests for lint on type dependent on consts - #97105
Merged
Merged
Conversation
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
2 times, most recently
from
May 17, 2022 06:19
e9d3f7b to
ba8835eCompareJulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
2 times, most recently
from
May 17, 2022 06:35
96ae797 to
c03b357CompareJulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
from
May 17, 2022 06:40
c03b357 to
edae6edCompareJulianKnodt
marked this pull request as ready for review
May 17, 2022 15:51
lcnr
reviewed
May 19, 2022
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
from
May 20, 2022 18:41
2fb723c to
814f18cComparelcnr
reviewed
May 21, 2022
Comment on lines
100
to
108
ContributorAuthor
There was a problem hiding this comment.
hm I tried it with unreachable!() and this branch actually gets hit
Contributor
There was a problem hiding this comment.
ah alright, can you because infcx.const_eval_resolve returns TooGeneric even if the inference vars are unused. Please change this to
Err(ErrorHandled::TooGeneric) => {assert!(uv.has_infer_types_or_consts(),"unexpected `TooGeneric` for {:?}", uv);NotConstEvaluatable::MentionsInfer}Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
lcnr
commented
May 23, 2022
Contributor
@bors delegate+ please fix my last nit and squash your commits, then r=me 👍 |
bors
commented
May 23, 2022
Collaborator
✌️ @JulianKnodt can now approve this pull request |
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
from
May 23, 2022 16:05
335b2ac to
dd64482Compare
This comment has been minimized.
This comment has been minimized.
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
2 times, most recently
from
May 23, 2022 16:34
cc9d5c3 to
031f4f4Compare
This comment has been minimized.
This comment has been minimized.
Contributor
uh that's just a bug with inconsistent where-clauses xx maybe change the assert to an |
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
from
May 24, 2022 03:27
031f4f4 to
ed89b85CompareMove a bunch of branches together into one if block, for easier reading. Resolve comments Attempt to make some branches unreachable [tmp] Revert unreachable branches
JulianKnodtforce-pushed
the
const_dep_gen_const_expr
branch
from
May 24, 2022 05:33
ed89b85 to
ee8efc5CompareJulianKnodt
commented
May 25, 2022
ContributorAuthor
@bors r=lcnr |
bors
commented
May 25, 2022
Collaborator
📌 Commit ee8efc5 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93604 (Make llvm-libunwind a per-target option) - rust-lang#97026 (Change orderings of `Debug` for the Atomic types to `Relaxed`.) - rust-lang#97105 (Add tests for lint on type dependent on consts) - rust-lang#97323 (Introduce stricter checks for might_permit_raw_init under a debug flag ) - rust-lang#97379 (Add aliases for `current_dir`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr