Uh oh!
There was an error while loading. Please reload this page.
Add implicit call to from_str via parse in documentation - #97190
Merged
Conversation
The documentation mentions "FromStr’s from_str method is often used implicitly, through str’s parse method. See parse’s documentation for examples.". It may be nicer to show that in the code example as well.
rust-highfive
commented
May 19, 2022
Contributor
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
May 19, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
Dylan-DPC
commented
May 21, 2022
Member
@bors r+ rollup |
bors
commented
May 21, 2022
Collaborator
📌 Commit 4c1daba has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2022
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#97190 (Add implicit call to from_str via parse in documentation) - rust-lang#97218 (Add eslint checks) - rust-lang#97219 (make ptr::invalid not the same as a regular int2ptr cast) - rust-lang#97223 (Remove quadratic behaviour from -Zunpretty=hir-tree.) - rust-lang#97232 (typo) - rust-lang#97237 (Add some more weird-exprs) - rust-lang#97238 (Bump LLVM fetched from CI to fix run-make) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation mentions "FromStr’s from_str method is often used implicitly,
through str’s parse method. See parse’s documentation for examples.".
It may be nicer to show that in the code example as well.