Uh oh!
There was an error while loading. Please reload this page.
Suggest extern crate foo when failing to resolve use foo - #97264
Merged
bors merged 1 commit intoJun 1, 2022
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TaKO8Kiforce-pushed
the
suggest-extern-crate-when-failing-to-resolve-use-crate
branch
from
May 22, 2022 04:27
b3ff096 to
938f0a4Compareestebank
commented
May 24, 2022
Contributor
Ideally we could provide a structured suggestion (we already look around for a span for Would you have the time to squash your commits? r=me either way. |
TaKO8Kiforce-pushed
the
suggest-extern-crate-when-failing-to-resolve-use-crate
branch
from
May 25, 2022 00:59
938f0a4 to
b2480a0CompareTaKO8Ki
commented
May 26, 2022
MemberAuthor
@estebank |
estebank
commented
Jun 1, 2022
Contributor
@bors r+ |
bors
commented
Jun 1, 2022
Collaborator
📌 Commit b2480a0 has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 1, 2022
…ailing-to-resolve-use-crate, r=estebank Suggest `extern crate foo` when failing to resolve `use foo` closesrust-lang#97095 r? `@estebank`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 1, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#96271 (suggest `?` when method is missing on `Result<T, _>` but found on `T`) - rust-lang#97264 (Suggest `extern crate foo` when failing to resolve `use foo`) - rust-lang#97592 (rustdoc: also index impl trait and raw pointers) - rust-lang#97621 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#97095
r? @estebank